[coq] Protect all base API calls #160
Merged
+156
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejgallego
force-pushed
the
protect_all_coq
branch
6 times, most recently
from
8819101
to
b0001cc
Compare
Work on tricky issues made me realize that we don't handle anomalies and Coq errors still in the best way, thus #91 is not really solved. There are 2 issues this PR solves: - goal printing can raise an anomalies and errors, due to setting state and printing, - it is safer to stop checking and set the document to failed when an anomaly happens (tho we could make this configurable). Thus, we go full principled in terms of API and make `Protect` mandatory on the exported APIs from `coq` library. We also introduce a `Failed` state that prevents further checking of that document without having finished it. Really fixes #91, and a step towards #153 TODO: protect calls to admit, but we leave this for a further PR as it is quite tricky due to error recovery needing rework to fully account for `Protect.R` results.
ejgallego
force-pushed
the
protect_all_coq
branch
from
b0001cc
to
5435734
Compare
ejgallego
added
part: lsp server
kind: upstream
kind: internal
kind: enhancement
ejgallego
added a commit
to ejgallego/opam-repository
that referenced
this pull request
Jan 15, 2023
CHANGES: ---------------------- - Much improved handling of Coq fatal errors, the server is now hardened against them (@ejgallego, ejgallego/coq-lsp#155, ejgallego/coq-lsp#157, ejgallego/coq-lsp#160, fixes ejgallego/coq-lsp#91) - `coq-lsp` now follows the LSP specification regarding initialization strictly (@ejgallego, ejgallego/coq-lsp#168) - New setting for goals to be updated when the selection changes due to a command; this makes VsCodeVim cursor tracking work; thanks to Cactus (Anton) Golov for detailed bug reporting and testing (@ejgallego, @jesyspa, ejgallego/coq-lsp#170, fixes ejgallego/coq-lsp#163) - `coq-lsp` will now warn the user when two files have been opened simultaneously and the parser may go into a broken state :/ (@ejgallego, ejgallego/coq-lsp#169) - Implement request postponement and cancellation. Thus `documentSymbols` will now be postponed until the document is ready, (@ejgallego, ejgallego/coq-lsp#141, ejgallego/coq-lsp#146, fixes ejgallego/coq-lsp#124) - Protocol and VS Code interfaces now support shelved and given_up goals (@ejgallego, ejgallego/coq-lsp#175) - Allow to postpone requests to wait for data to become available on document points; this is implemented to provide a nicer "show goals while I type" experience. Client default has been changed to "show goals on mouse, click, typing, and cursor movement) (@ejgallego, ejgallego/coq-lsp#177, ejgallego/coq-lsp#179) - Store stats per document (@ejgallego, ejgallego/coq-lsp#180, fixes ejgallego/coq-lsp#173)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work on tricky issues made me realize that we don't handle anomalies
and Coq errors still in the best way, thus #91 is not really solved.
There are 2 issues this PR solves:
to setting state and printing,
anomaly happens (tho we could make this configurable).
Thus, we go full principled in terms of API and make
Protectmandatory on the exported APIs from
coqlibrary.We also introduce a
Failedstate that prevents further checking ofthat document without having finished it.
Really fixes #91, and a step towards #153
TODO: protect calls to admit, but we leave this for a further PR as it
is quite tricky due to error recovery needing rework to fully account
for
Protect.Rresults.