Skip to content
This repository has been archived by the owner on Apr 10, 2021. It is now read-only.

Complete parseAlgebraicMove #6

Closed
ejnnr opened this issue Nov 26, 2014 · 0 comments
Closed

Complete parseAlgebraicMove #6

ejnnr opened this issue Nov 26, 2014 · 0 comments

Comments

@ejnnr
Copy link
Owner

ejnnr commented Nov 26, 2014

There are quite a few things to do to complete the function parseAlgebraicMove in include/ChessGame.php.

  • the castling routine is incomplete; it needs to check whether castling is a valid move.
  • the function needs better exception handling, e.g. exceptions should be thrown if the move in question is not legal or there is more than one move
  • of course the function needs to return something instead of showing test output
  • annotation symbols need to be parsed too

EDIT: No. 1-3 are done, only the annotation symbols aren't parsed yet

f04010e also added checking whether there's more than one possible move and throwing an exception if so.

@ejnnr ejnnr self-assigned this Nov 27, 2014
@ejnnr ejnnr added the Backend label Mar 9, 2015
@ejnnr ejnnr closed this as completed in 5c3a752 Apr 8, 2015
@ejnnr ejnnr added this to the Version 0.1.0 milestone Dec 22, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant