Marking a commit WIP after-the-fact seems to lead to confusion

[leoluk]

I marked the top commit on this stack WIP and inserted another commit beneath it:

... which somehow lead to this PRs body changing:

#155

... to the old message of #147. Not sure what happened here?

Removing the "WIP" title and re-running spr undid the damage.

[ejoffe]

This code path is untested and very minimally used, so I can't say I'm surprised there is some weird behavior.
If I have some spare cycles in the next couple of weeks, I'll look into this.

[ejoffe]

@leoluk - I recently also ran into an issue in this area. My current thinking is to completely ignore all commits in the stack starting from the WIP commit. This means that if you have a bunch of PRs in the stack and mark some PR in the middle as WIP, spr update will close all the PRs starting from the WIP going upwards.
I think this is correct behavior and avoids weird corner cases, but might lead to surprising results (prs closing that don't have wip but are above a wip pr). Thoughts?

[leoluk]

There's no point to have a non-WIP PR on top of a WIP one so this makes sense to me.

[ejoffe]

I think this is fixed now.