Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.nam to .nam.stripe conversion failure #16

Closed
rlnilsen opened this issue Oct 22, 2020 · 2 comments
Closed

.nam to .nam.stripe conversion failure #16

rlnilsen opened this issue Oct 22, 2020 · 2 comments

Comments

@rlnilsen
Copy link
Contributor

rlnilsen commented Oct 22, 2020 •
edited
Loading

A .nam file containing 0xd,0xa will mess up the conversion to .nam.stripe. The issue can be fixed by adding -v BINMODE=3 to the relevant awk command in Makefile. This probably also applies to the reverse conversion.

Edit:
This was on Win10 x64 1909, set up as instructed under "How to build" in README.md.

I also created PR #17 for this issue, mostly for my own learning experience. You can use it if you want.
@ejona86
Copy link
Owner

ejona86 commented Oct 23, 2020

Fixed by #17.

I'm a bit surprised I've not had any other interpreted-as-text Windows issues. Thanks for tracking down the issue and fixing. I know they can be annoying to debug, especially with how much scripting this project uses.

@ejona86 ejona86 closed this as completed Oct 23, 2020
@rlnilsen
Copy link
Contributor Author

It was an insignificant use of time compared to what is saved by this framework for creating Tetris mods. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ejona86 @rlnilsen