Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2-Player] B-Type Issues #18

Closed
SapphireBulletBill opened this issue Oct 24, 2020 · 4 comments
Closed

[2-Player] B-Type Issues #18

SapphireBulletBill opened this issue Oct 24, 2020 · 4 comments

Comments

@SapphireBulletBill
Copy link

SapphireBulletBill commented Oct 24, 2020

This is already an awesome modification. However, B-Type has a couple problems.
(This was encountered on the "Next-on-top" version, though I'd expect it to be the same on the other version)

  • Game crashes after finishing a B-Type game.
  • When a player finishes, the other player doesn't get to finish.
@ejona86
Copy link
Owner

ejona86 commented Nov 1, 2020

@DanKruse731, what version of the hack are you using? Where did you get it? I tested v1.1.1, v1.2.0, and master with next-on-top and don't see any problem. I tried both p1 and p2 dying first. Super-early versions of the hack did crash when one player died, but those aren't widely distributed.

@SapphireBulletBill
Copy link
Author

@DanKruse731, what version of the hack are you using? Where did you get it? I tested v1.1.1, v1.2.0, and master with next-on-top and don't see any problem. I tried both p1 and p2 dying first. Super-early versions of the hack did crash when one player died, but those aren't widely distributed.

I'm using release 1.2.0

@ejona86
Copy link
Owner

ejona86 commented Nov 1, 2020

Oh, I found it. It's when you complete B type normally, without dying. Yeah, I totally missed that code path and didn't consider testing it.

This is probably pretty easy to fix, but I'll also need to look back at how I fixed Type A, and I remember that had some ugly code to avoid messing up some common GameGenie codes.

@ejona86
Copy link
Owner

ejona86 commented Nov 10, 2020

Thanks for filing the issue! It turned out to be easy to fix it in a basic way, but quite a bit more involved to have the music play as I wanted. I ended up getting it though. v1.3.0 includes the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants