Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undetermined gender filter is not working #22

Closed
kkr-ait opened this issue Jul 6, 2023 · 3 comments
Closed

Undetermined gender filter is not working #22

kkr-ait opened this issue Jul 6, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@kkr-ait
Copy link

kkr-ait commented Jul 6, 2023

Describe your problem.

It seems the "Undetermined" gender filter is not working correctly.

If it is a bug name steps to reproduce

Searching for orpha code 730 and choosing "undetermined" as filter gives 1014 results

Describe the solution you'd like

I think it should be < 1014

Additional context

Probably related to #21

@kkr-ait kkr-ait added the bug Something isn't working label Jul 6, 2023
@kkr-ait
Copy link
Author

kkr-ait commented Jul 6, 2023

@vabishaa @Ammarbr @HaddadTala

@ammarbarakat
Copy link
Contributor

thanks @kkr-ait for bringing up the issue. Honestly, I'm not exactly sure what the right response should be for the gender "undetermined". All I could do was double-check the filters, and they seem to be working fine. @rini21 Can you help us out and let us know what the correct resultCount should be for this request? Appreciate it!

@rini21
Copy link

rini21 commented Jul 6, 2023

@kkr-ait @Ammarbr this is happening because the filter value is unsupported by this resource and is ignored, and a partial request is being performed. My suggestion would be for VP-Portal to make use of the 'warnings' section incoming in the response to look for 'unsupportedFilters' or 'unsupportedFilterValues' and let the user know that those filter(s)/value(s) will be ignored.

For now, we have disabled ignoring unsupported filters and the endpoint gives back the correct count '0', and hence will not display ERKReg in the results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants