Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ BUG ] Examples / docs with sequential write without a callback are not ideal #428

Open
huntharo opened this issue May 21, 2024 · 0 comments

Comments

@huntharo
Copy link
Contributor

Describe the bug

  • The examples where we write to a sitemap or index with .write('item') repeated, are not correct / not ideal
  • These write calls do not respect backpressure because they do not wait for the callback to be called before writing another item

Expected behavior

We can change these to use a promisified version of write to show how to make multiple writes while respecting back pressure and handling errors as they happen

Context:

  • Library Version 7.1.1

Additional context

None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant