Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use jstoxml instead of doing string concatenation everywhere #65

Closed
rauberdaniel opened this issue Mar 17, 2016 · 2 comments
Closed

Use jstoxml instead of doing string concatenation everywhere #65

rauberdaniel opened this issue Mar 17, 2016 · 2 comments

Comments

@rauberdaniel
Copy link
Contributor

What do you think about using a dependency (e.g. https://github.com/davidcalhoun/jstoxml) to create a valid xml output instead of doing string concatenations? In my opinion this would definitely make the code easier to understand and maintain.

@ekalinin
Copy link
Owner

ekalinin commented Apr 1, 2016

Hey @rauberdaniel

Thanks for the propose.
But to be honest i don't want to add one more dependency.
But will think about it.

@derduher
Copy link
Collaborator

derduher commented Jul 1, 2019

We have since updated to use xml builder lib. So we are no longer manually concatenating strings.

@derduher derduher closed this as completed Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants