Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PageCreator should return Promise<Page> or Page or void #9

Closed
rande opened this issue Oct 24, 2019 · 0 comments
Closed

PageCreator should return Promise<Page> or Page or void #9

rande opened this issue Oct 24, 2019 · 0 comments

Comments

@rande
Copy link
Contributor

rande commented Oct 24, 2019

For now the PageCreator should allows to return multiple types:

  • Page: if there is no async code in the function
  • void: if the pageCreator take over the request (ie: a case where the function return binary data)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rande