Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop 'either' dependency #69

Closed
glguy opened this issue May 30, 2014 · 3 comments
Closed

Drop 'either' dependency #69

glguy opened this issue May 30, 2014 · 3 comments

Comments

@glguy
Copy link
Collaborator

glguy commented May 30, 2014

The new 'either' package dependency drags in transitive dependencies on "transformers-base" "MonadRandom" "monad-control" into upstream packages like "lens".

This instance might not be worth the dependency cost.

@ocharles
Copy link
Contributor

Why is that a problem? It's a useful instance for us :(

@ekmett
Copy link
Owner

ekmett commented May 31, 2014

A concern I have about it is that the instance isn't actually "free". One option might be to invert the dependency and make either depend on free.

Most of the users of errors bring in free anyways as the former is Gabriel's baby.

Given the existence of ExceptT, now EitherT is more of a fringe type.

@ekmett ekmett closed this as completed in 02d8d4d Jun 1, 2014
@ekmett
Copy link
Owner

ekmett commented Jun 1, 2014

Moved the instance to either. Now the complaining can start anew there. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants