Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize the signature of Getting and IndexedGetting #34

Closed
ekmett opened this issue Sep 4, 2012 · 1 comment
Closed

Generalize the signature of Getting and IndexedGetting #34

ekmett opened this issue Sep 4, 2012 · 1 comment
Assignees
@ekmett
Labels
enhancement
Milestone
2.7

Comments

@ekmett
Copy link
Owner

ekmett commented Sep 4, 2012

As it is, when you are given a lens/traversal that you plan to use to change the type of a field, it is hard to use any getting or fold combinators on it.

I think the best compromise is to keep Getter and Fold in their two argument form and add the other two args back to Getting and IndexedGetting.
@ghost ghost assigned ekmett Sep 4, 2012
@ekmett
Copy link
Owner Author

ekmett commented Sep 4, 2012

Done. Will be in 2.7

@ekmett ekmett closed this as completed Sep 4, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ekmett ekmett

Labels
enhancement
Projects
None yet
Milestone
2.7
Development

No branches or pull requests
1 participant
@ekmett