Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release request and doc updates to fix rediscluster v9 #214

Closed
ashtonian opened this issue Jul 11, 2023 · 4 comments
Closed

release request and doc updates to fix rediscluster v9 #214

ashtonian opened this issue Jul 11, 2023 · 4 comments

Comments

@ashtonian
Copy link
Contributor

ashtonian commented Jul 11, 2023

I think https://pkg.go.dev/ needs to be updated as it states v3 is the latest version.

Additionally could you do a release to enable redis v9 client ? right now using go get, it pulls v4.1.2 which doesn't include the change. I think the only way to access it then is to use go get with a commit hash off master I think that conflicts with the versioning (ie v4 in github.com/eko/gocache/lib/v4).

@ashtonian ashtonian changed the title out of date https://pkg.go.dev/ Inconsistent versioning? Jul 11, 2023
@ashtonian ashtonian changed the title Inconsistent versioning? release request and doc updates Jul 11, 2023
@ashtonian
Copy link
Contributor Author

This only seems to be an issue with rediscluster as it seems redis/v4 has a newer tag published with the changes 4.2.0.

	github.com/eko/gocache/store/redis/v4 v4.2.0
	github.com/eko/gocache/store/rediscluster/v4 v4.1.2

@ashtonian ashtonian changed the title release request and doc updates release request and doc updates to fix rediscluster v9 Jul 11, 2023
@ashtonian
Copy link
Contributor Author

I was able to fix that issue. I think the docs just need to be updated at pkg.go.dev to reflect v4.

@eko
Copy link
Owner

eko commented Aug 7, 2023

Hi @ashtonian, you're right the package was not updated on pkg.go.dev for v4 branch.

I requested an update here: https://pkg.go.dev/github.com/eko/gocache/lib/v4 and it should be available as soon as the Golang bot will crawl the package ;-)

@eko
Copy link
Owner

eko commented Aug 7, 2023

Closing this issue as the documentation is now up-to-date on pkg.go.dev.

Thank you, feel free to reopen if you still have any issue!

@eko eko closed this as completed Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants