Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Ctrl-C signal not handled if labels not found on forwards #17
Another issue that's kind of allowing I noticed, might as well raise it, should be easy to fix. If I start some forwards and the namespace does not contain the deployment with the labels specified, then it's going to hang forever, and no feedback at all from the program just blank screen. It would be nice to first have some feedback whats it trying to do, here find the deployment with those labels, maybe even print the labels its looking for, so we might realise we made an error or wrong namespace.
If you have sometime to work on that at some point, I wouldn't say its high priority but a nice to have.
Thanks for the tool again.
Steps for Reproduction*
The program is closed properly.
Nothing happens, manually killing the process then put that shell in a "bad" state.
Linux Ubuntu 18.04 / Mac OS
Maybe this has been fixed since the
I added the following configuration:
# A non-existant label match on Kubernetes <: &unknown-service-kubernetes name: unknown-service type: kubernetes values: context: *kubernetes-context namespace: platform hostname: unknown.svc.local labels: app: this-is-totally-unknown-from-kubernetes ports: - 8080:8080 # A project with this non-existant forward projects: - name: Unknown service (forward) forward: - *unknown-service-kubernetes
Then, when I run Monday and select this project, I have the following output and when I hit "Ctrl+C", it's OK:
$ monday ✔ Unknown service (forward) 📡 Forwarding 'unknown-service' over kubernetes... ✅ Successfully mapped hostname 'unknown.svc.local' with IP '127.1.2.1' and port 9401 🔌 Proxifying unknown.svc.local locally (127.1.2.1:8080) <-> forwarding to 127.0.0.1:9401 No pod available for selector 'app=this-is-totally-unknown-from-kubernetes': <nil> 👓 Forwarder: lost port-forward connection trying to reconnect... No pod available for selector 'app=this-is-totally-unknown-from-kubernetes': <nil> 👓 Forwarder: lost port-forward connection trying to reconnect... No pod available for selector 'app=this-is-totally-unknown-from-kubernetes': <nil> 👓 Forwarder: lost port-forward connection trying to reconnect... ^C 👋 Bye, closing your local applications and remote connections now
I've also tried using the UI with
Could you please close this issue if it's fixed for you too?