Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PULL_REQUEST_TEMPLATE #57

Closed
vasylnahuliak opened this issue Oct 26, 2023 · 6 comments
Closed

Add PULL_REQUEST_TEMPLATE #57

vasylnahuliak opened this issue Oct 26, 2023 · 6 comments
Assignees
@dakshsinghrathore
Labels
documentation Improvements or additions to documentation

Comments

@vasylnahuliak
Copy link
Collaborator

https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/creating-a-pull-request-template-for-your-repository
@vasylnahuliak vasylnahuliak added hacktoberfest documentation Improvements or additions to documentation labels Oct 27, 2023
@dakshsinghrathore
Copy link
Contributor

Hey @vasylnahuliak would love to work on this issue, can you share the details you would like to add in the template, any specifics one should take care of ???

@vasylnahuliak
Copy link
Collaborator Author

vasylnahuliak commented Oct 27, 2023 •
edited
Loading

@dakshsinghrathore Now, I do not have any special thing. I guess we need to start with a popular scenario. In the future, we will be detailing this.

Try to find a popular react-native library and take inspiration.

@dakshsinghrathore
Copy link
Contributor

Got it @vasylnahuliak

@dakshsinghrathore dakshsinghrathore mentioned this issue Oct 28, 2023
Merged
@vasylnahuliak
Copy link
Collaborator Author

Done in #76

Thanks!

@vasylnahuliak
Copy link
Collaborator Author

@dakshsinghrathore Could you fix lint errors? https://github.com/ekreative/react-native-braintree/actions/runs/6689733039/job/18173761098

@dakshsinghrathore
Copy link
Contributor

dakshsinghrathore commented Oct 30, 2023 •
edited
Loading

@vasylnahuliak yeah sure, will create a PR soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dakshsinghrathore dakshsinghrathore

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vasylnahuliak @dakshsinghrathore