Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve base_controller #16

Open
jubeira opened this issue Jan 26, 2017 · 0 comments
Open

Improve base_controller #16

jubeira opened this issue Jan 26, 2017 · 0 comments

Comments

@jubeira
Copy link
Contributor

jubeira commented Jan 26, 2017

A general review of the code should be performed. The module has some details that can be improved without an excessive effort.

  • The basic code publishes the odometry at 10 Hz using standard thread functions. This can be improved using higher rates and ROS Rate functions. The rate could be configurable too.
  • Some of the transformations being published are not necessary (e.g. laser_link).
  • The basic code publishes odometry using base_link as its target frame. The name could be configurable somehow (for example, publishing base_footprint proved to be useful in tests).
  • General cleanup of "To Do"s.
@jubeira jubeira added this to the Contributions to third party milestone Feb 17, 2017
@adamantivm adamantivm removed this from the Contributions to third party milestone Jun 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants