Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reordered sponge4 failure #183

Closed
elalish opened this issue Aug 9, 2022 · 0 comments · Fixed by #184
Closed

reordered sponge4 failure #183

elalish opened this issue Aug 9, 2022 · 0 comments · Fixed by #184
Assignees
Labels
bug Something isn't working

Comments

@elalish
Copy link
Owner

elalish commented Aug 9, 2022

I managed to repro the problem from #171 on master by manually reordering the sponge operations. Many different orders worked fine, but this one, which is most similar to the result of the other PR, did not:

Manifold tmp1 = hole.Rotate(90) + hole.Rotate(90).Rotate(0, 0, 90);
Manifold tmp2 = hole + tmp1;
result = result - tmp2;

Not only did it come up with 39k degenerate triangles, it also ended up with the wrong genus. It's pretty clear there's a problem:
Screenshot from 2022-08-09 09-35-51

@elalish elalish added the bug Something isn't working label Aug 9, 2022
@elalish elalish self-assigned this Aug 9, 2022
This was referenced Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant