Add option to specify series in the uploader #675
Assignees
Labels
area:frontend
Everything frontend related
area:search
Related to Tobira's search
kind:new-feature
A new feature
Comments
LukasKalbertodt
added
area:frontend
|
Discussion im meeting:
After this first implementation further discussion is needed if a connection to a 'user's series' is needed (if no series gets specified). |
owi92
added a commit
that referenced
this issue
Feb 15, 2023
…ch index) (#705) Fixes #675 This PR: - Adds the `search_series` DB view (which is used to populate the search index). - Installs the appropriate triggers to make sure series are added to the `search_index_queue` when necessary. - Adds a search index for series and populates it correctly. - Uses that search index to make a `SearchableSelect` work with series. - Uses that `SearchableSelect` to add a series selection to the uploader. Additionally, I added tests to make sure all those triggers work as expected. Those tests revealed that, in fact, those triggers didn't work as expected. So another migration was added to fix those bugs. See commit messages for more information. Probably review commit by commit. (Though the last two commits change previous code, be aware.) As series are now indexed, we could make the main search now also return series. I would wait with that though until Meili allows multi-index search. I noticed that in our test data, there aren't many series that have non-empty `write_roles`. So even Sabine can upload in just 2 series right now. But this "requires write permission to series" is the only sane condition we can use, and it was specified like that in #675.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Fairly straight forward: users might want to directly upload a video into a series. Technically, specifying that in the metadata catalog is easy. We need a searchable select box for that. Thus, I think #360 is a blocker for this.
Regarding "what series can be seen": people decided that we can simply use the series
writeACL here. Make the series selectable here iff the user has write access.The text was updated successfully, but these errors were encountered: