Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if a transaction is active #762

Closed
wants to merge 1 commit into from
Closed

Check if a transaction is active #762

wants to merge 1 commit into from

Conversation

randomswdev
Copy link
Contributor

Check if tx is not nil befiore using it. See issue #761

@cla-checker-service
Copy link

❌ Author of the following commits did not sign a Contributor Agreement:
b5f0ffe

Please, read and sign the above mentioned agreement if you want to contribute to this project

@apmmachine
Copy link
Contributor

💔 Build Failed

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

Steps errors

Expand to view the steps failures

  • Name: Error signal

    • Description: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permission

    • Result: FAILURE

    • Duration: 0 min 0 sec<

    • Start Time: 2020-05-05T21:12:28.074+0000

Log output

Expand to view the last 100 lines of log output 

[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/692/head -> origin/pr/692
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/693/head -> origin/pr/693
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/695/head -> origin/pr/695
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/696/head -> origin/pr/696
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/697/head -> origin/pr/697
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/698/head -> origin/pr/698
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/7/head   -> origin/pr/7
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/70/head  -> origin/pr/70
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/700/head -> origin/pr/700
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/701/head -> origin/pr/701
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/702/head -> origin/pr/702
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/703/head -> origin/pr/703
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/705/head -> origin/pr/705
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/706/head -> origin/pr/706
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/707/head -> origin/pr/707
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/709/head -> origin/pr/709
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/71/head  -> origin/pr/71
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/711/head -> origin/pr/711
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/713/head -> origin/pr/713
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/714/head -> origin/pr/714
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/715/head -> origin/pr/715
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/716/head -> origin/pr/716
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/717/head -> origin/pr/717
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/718/head -> origin/pr/718
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/719/head -> origin/pr/719
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/72/head  -> origin/pr/72
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/720/head -> origin/pr/720
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/721/head -> origin/pr/721
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/722/head -> origin/pr/722
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/724/head -> origin/pr/724
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/726/head -> origin/pr/726
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/728/head -> origin/pr/728
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/73/head  -> origin/pr/73
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/730/head -> origin/pr/730
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/732/head -> origin/pr/732
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/733/head -> origin/pr/733
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/734/head -> origin/pr/734
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/735/head -> origin/pr/735
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/737/head -> origin/pr/737
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/738/head -> origin/pr/738
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/739/head -> origin/pr/739
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/74/head  -> origin/pr/74
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/740/head -> origin/pr/740
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/742/head -> origin/pr/742
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/743/head -> origin/pr/743
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/744/head -> origin/pr/744
[2020-05-05T21:12:24.904Z]  * [new ref]         refs/pull/745/head -> origin/pr/745
[2020-05-05T21:12:24.905Z]  * [new ref]         refs/pull/746/head -> origin/pr/746
[2020-05-05T21:12:24.905Z]  * [new ref]         refs/pull/747/head -> origin/pr/747
[2020-05-05T21:12:24.905Z]  * [new ref]         refs/pull/748/head -> origin/pr/748
[2020-05-05T21:12:24.905Z]  * [new ref]         refs/pull/75/head  -> origin/pr/75
[2020-05-05T21:12:24.905Z]  * [new ref]         refs/pull/750/head -> origin/pr/750
[2020-05-05T21:12:24.905Z]  * [new ref]         refs/pull/751/head -> origin/pr/751
[2020-05-05T21:12:24.905Z]  * [new ref]         refs/pull/754/head -> origin/pr/754
[2020-05-05T21:12:24.905Z]  * [new ref]         refs/pull/755/head -> origin/pr/755
[2020-05-05T21:12:24.905Z]  * [new ref]         refs/pull/757/head -> origin/pr/757
[2020-05-05T21:12:24.905Z]  * [new ref]         refs/pull/758/head -> origin/pr/758
[2020-05-05T21:12:24.905Z]  * [new ref]         refs/pull/759/head -> origin/pr/759
[2020-05-05T21:12:24.905Z]  * [new ref]         refs/pull/760/head -> origin/pr/760
[2020-05-05T21:12:24.905Z]  * [new ref]         refs/pull/762/head -> origin/pr/762
[2020-05-05T21:12:24.905Z]  * [new ref]         refs/pull/77/head  -> origin/pr/77
[2020-05-05T21:12:24.905Z]  * [new ref]         refs/pull/78/head  -> origin/pr/78
[2020-05-05T21:12:24.905Z]  * [new ref]         refs/pull/79/head  -> origin/pr/79
[2020-05-05T21:12:24.905Z]  * [new ref]         refs/pull/8/head   -> origin/pr/8
[2020-05-05T21:12:24.905Z]  * [new ref]         refs/pull/80/head  -> origin/pr/80
[2020-05-05T21:12:24.905Z]  * [new ref]         refs/pull/81/head  -> origin/pr/81
[2020-05-05T21:12:24.905Z]  * [new ref]         refs/pull/82/head  -> origin/pr/82
[2020-05-05T21:12:24.905Z]  * [new ref]         refs/pull/87/head  -> origin/pr/87
[2020-05-05T21:12:24.905Z]  * [new ref]         refs/pull/9/head   -> origin/pr/9
[2020-05-05T21:12:24.905Z]  * [new ref]         refs/pull/90/head  -> origin/pr/90
[2020-05-05T21:12:24.905Z]  * [new ref]         refs/pull/91/head  -> origin/pr/91
[2020-05-05T21:12:24.905Z]  * [new ref]         refs/pull/92/head  -> origin/pr/92
[2020-05-05T21:12:24.905Z]  * [new ref]         refs/pull/93/head  -> origin/pr/93
[2020-05-05T21:12:24.905Z]  * [new ref]         refs/pull/94/head  -> origin/pr/94
[2020-05-05T21:12:24.905Z]  * [new ref]         refs/pull/95/head  -> origin/pr/95
[2020-05-05T21:12:24.905Z]  * [new ref]         refs/pull/97/head  -> origin/pr/97
[2020-05-05T21:12:25.581Z] + git rev-parse HEAD
[2020-05-05T21:12:25.959Z] + git rev-parse HEAD
[2020-05-05T21:12:26.270Z] + git rev-parse origin/pr/762
[2020-05-05T21:12:26.322Z] [INFO] githubEnv: Found Git Build Cause: pr
[2020-05-05T21:12:26.735Z] Masking supported pattern matches of $GITHUB_TOKEN
[2020-05-05T21:12:27.749Z] [WARN] githubApiCall: The REST API call https://api.github.com/repos/elastic/apm-agent-go/pulls/762/reviews return 0 elements
[2020-05-05T21:12:27.811Z] [INFO] githubPrCheckApproved: Title: Check if a transaction is active - User: randomswdev - Author Association: FIRST_TIME_CONTRIBUTOR
[2020-05-05T21:12:29.263Z] Stage "Tests" skipped due to earlier failure(s)
[2020-05-05T21:12:29.351Z] Stage "Coverage" skipped due to earlier failure(s)
[2020-05-05T21:12:29.441Z] Stage "Benchmark" skipped due to earlier failure(s)
[2020-05-05T21:12:29.623Z] Stage "More OS" skipped due to earlier failure(s)
[2020-05-05T21:12:29.719Z] Stage "Windows" skipped due to earlier failure(s)
[2020-05-05T21:12:29.730Z] Stage "OSX" skipped due to earlier failure(s)
[2020-05-05T21:12:29.816Z] Failed in branch Windows
[2020-05-05T21:12:29.825Z] Failed in branch OSX
[2020-05-05T21:12:29.978Z] Stage "Integration Tests" skipped due to earlier failure(s)
[2020-05-05T21:12:30.061Z] Stage "Release" skipped due to earlier failure(s)
[2020-05-05T21:12:30.102Z] Stage "Release" skipped due to earlier failure(s)
[2020-05-05T21:12:30.405Z] Running on Jenkins in /var/lib/jenkins/workspace/agent-go_apm-agent-go-mbp_PR-762
[2020-05-05T21:12:30.705Z] [INFO] getVaultSecret: Getting secrets
[2020-05-05T21:12:30.765Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-05-05T21:12:31.532Z] + chmod 755 generate-build-data.sh
[2020-05-05T21:12:31.532Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-go/apm-agent-go-mbp/PR-762/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-go/apm-agent-go-mbp/PR-762/runs/1 FAILURE 323382
[2020-05-05T21:12:32.083Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-go/apm-agent-go-mbp/PR-762/runs/1/steps/?limit=10000 -o steps-info.json

@axw
Copy link
Member

axw commented May 6, 2020

@randomswdev thanks for opening the PR!

I'm about to create a new release and I'd love to get this fix in, however I'd need you to sign the CLA first. I would also like to add a test. As it's a trivial fix, I'll create a new PR.

@axw axw mentioned this pull request May 6, 2020
Merged
@axw
Copy link
Member

axw commented May 6, 2020

Superseded by #763, so closing this one. Thanks again for reporting the issue and putting up the PR.

@axw axw closed this May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@randomswdev @apmmachine @axw