Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure while Injecting a context #761

Closed
randomswdev opened this issue May 5, 2020 · 0 comments · Fixed by #763
Closed

Failure while Injecting a context #761

randomswdev opened this issue May 5, 2020 · 0 comments · Fixed by #763

Comments

@randomswdev
Copy link
Contributor

Describe the bug
An application using apmot terminates unexpectedly because of a null pointer.

To Reproduce
I'm reproducing this in a complex environment. But looking at the methods Inject and Extract in module/apmot/tracer.go, the extract method returns a SpanContext with the tx field set to nil. On the other side the Inject method uses the value returned by spanContext.Transaction() without checking it. This generates the null pointer dereference.

Expected behavior
The application to run successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant