Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump mysql2 from 2.3.3 to 3.1.0 #3146

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 6, 2023

Bumps mysql2 from 2.3.3 to 3.1.0.

Release notes

Sourced from mysql2's releases.

v3.1.0

3.1.0 (2023-01-30)

Features

  • cleanup buffer/string conversions in hashing/xor helpers that were failing in Bun (a2392e2)

Bug Fixes

  • when port is pased as a string convert it to a number (Bun's net.connect does not automatically convert this) (703ecb2)

v3.0.1

3.0.1 (2023-01-13)

Dependencies

Miscellaneous Chores

v3.0.0

3.0.0 (2023-01-12)

Miscellaneous Chores

( below is manually added while I'm trying to iron release-please issues and commits style )

Changes

  • named-placeholders library is updated to use newer lru-cache dependency, allowing it do dedupe and be shared between mysql2 and named-placeholders - sidorares/node-mysql2#1711, mysqljs/named-placeholders#19
  • chai and mocha moved to devDependencies #1774
  • Amazon RDS ssl certificates updated including AWS China #1754
  • TCP_NODELAY flag enabled, avoiding long connect timeout in some scenarios #1751
  • typing improvements: #1675, #1674
  • fix: ensure pooled connections get released #1666

v3.0.0-rc.1

3.0.0-rc.1 (2022-11-06)

Bug Fixes

  • typings: Add the infileStreamFactory option to the type definition (bf9cc4c)

... (truncated)

Changelog

Sourced from mysql2's changelog.

3.1.0 (2023-01-30)

Features

  • cleanup buffer/string conversions in hashing/xor helpers that were failing in Bun (a2392e2)

Bug Fixes

  • when port is pased as a string convert it to a number (Bun's net.connect does not automatically convert this) (703ecb2)

3.0.1 (2023-01-13)

Miscellaneous Chores

3.0.0 (2023-01-12)

  • named-placeholders library is updated to use newer lru-cache dependency, allowing it do dedupe and be shared between mysql2 and named-placeholders - sidorares/node-mysql2#1711, mysqljs/named-placeholders#19
  • chai and mocha moved to devDependencies #1774
  • Amazon RDS ssl certificates updated including AWS China #1754
  • TCP_NODELAY flag enabled, avoiding long connect timeout in some scenarios #1751
  • typing improvements: #1675, #1674
  • fix: ensure pooled connections get released #1666

Miscellaneous Chores

3.0.0-rc.1 (2022-11-06)

Bug Fixes

  • typings: Add the infileStreamFactory option to the type definition (bf9cc4c)
  • webpack projects no longer show warning for cardinal dependency (26c56ae)

Miscellaneous Chores

3.0.0-rc.1 ( 6/11/2021 )

  • fix .ping() return value signature #1650
  • documentation: clarify SUM() and AVG() return types difference with mysqljs/myql #1649
  • misc: add release-please action #1631, #1647

... (truncated)

Commits
  • 93fe86e Merge pull request #1811 from sidorares/release-please--branches--master--com...
  • b33b597 chore(master): release 3.1.0
  • ec404e7 Merge pull request #1805 from sidorares/bun-support
  • a2392e2 feat: cleanup buffer/string conversions in hashing/xor helpers that were fail...
  • 703ecb2 fix: when port is pased as a string convert it to a number (Bun's net.connect...
  • 8389bfe build: add Bun to ci matrix
  • 8a000e0 Merge pull request #1806 from sidorares/dependabot/npm_and_yarn/typescript-es...
  • 87fa5f8 Merge pull request #1807 from sidorares/dependabot/npm_and_yarn/typescript-es...
  • bc0cf01 build(deps-dev): bump @​typescript-eslint/parser from 5.48.2 to 5.49.0
  • 2bdd24a build(deps-dev): bump @​typescript-eslint/eslint-plugin
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Feb 6, 2023
@dependabot dependabot bot requested a review from a team February 6, 2023 00:07
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Feb 6, 2023
@elastic-apm-tech elastic-apm-tech added this to In Progress in APM-Agents (OLD) Feb 6, 2023
@apmmachine
Copy link
Collaborator

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-06T00:07:44.684+0000

  • Duration: 183 min 58 sec

Steps errors 1

Expand to view the steps failures

Error signal
  • Took 0 min 0 sec . View more details here
  • Description: org.jenkinsci.plugins.workflow.steps.FlowInterruptedException

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run module tests for <modules> : Run TAV tests for one or more modules, where <modules> can be either a comma separated list of modules (e.g. memcached,redis) or the string literal ALL to test all modules

  • run benchmark tests : Run the benchmark test only.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@trentm trentm mentioned this pull request Feb 6, 2023
@trentm
Copy link
Member

trentm commented Feb 6, 2023

@dependabot ignore this major version

See #3151

@dependabot dependabot bot closed this Feb 6, 2023
APM-Agents (OLD) automation moved this from In Progress to Done Feb 6, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 6, 2023

OK, I won't notify you about version 3.x.x again, unless you re-open this PR. 😢

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/mysql2-3.1.0 branch February 6, 2023 19:13
@trentm
Copy link
Member

trentm commented May 13, 2024

Apparently this ancient "ignore this major version" was a blocker to dependabot doing mysql2@3 high security updates, even though we had subsequently updated to mysql2@3. See https://github.com/elastic/apm-agent-nodejs/security/dependabot/82
Lovely.

It is (or was) a known issue that dependabot ignores can get you into pickles and there is no dashboard or reasonable interface to resolve them.

[dependabot]

OK, I won't notify you about version 3.x.x again, unless you re-open this PR. 😢

However, the "Reopen and comment" button on this PR is disabled. Gah.

@trentm trentm restored the dependabot/npm_and_yarn/mysql2-3.1.0 branch May 13, 2024 15:48
@trentm trentm reopened this May 13, 2024
@trentm
Copy link
Member

trentm commented May 13, 2024

However, the "Reopen and comment" button on this PR is disabled. Gah.

Slightly subtle. One needs to "restore this branch" first, and then Re-open the PR.

@trentm
Copy link
Member

trentm commented May 13, 2024

@dependabot recreate

Bumps [mysql2](https://github.com/sidorares/node-mysql2) from 2.3.3 to 3.1.0.
- [Release notes](https://github.com/sidorares/node-mysql2/releases)
- [Changelog](https://github.com/sidorares/node-mysql2/blob/master/Changelog.md)
- [Commits](sidorares/node-mysql2@v2.3.3...v3.1.0)

---
updated-dependencies:
- dependency-name: mysql2
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/mysql2-3.1.0 branch from 80369ca to 527a1a7 Compare May 13, 2024 15:51
@trentm
Copy link
Member

trentm commented May 13, 2024

This should be obsoleted by #4021
We shall see if dependabot realizes that automatically.

@trentm
Copy link
Member

trentm commented May 13, 2024

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github May 13, 2024

Looks like mysql2 is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this May 13, 2024
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/mysql2-3.1.0 branch May 13, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning. dependencies Pull requests that update a dependency file
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants