Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Sneakers #676

Merged
merged 7 commits into from
Jan 9, 2020
Merged

Add support for Sneakers #676

merged 7 commits into from
Jan 9, 2020

Conversation

mikker
Copy link
Contributor

@mikker mikker commented Jan 8, 2020

Continued from #599

Updating the implementation and spec a little bit. I don't feel we need to include version checking in the spec unless explicitly testing with different versions.

@redwrx has an open PR here (jondot/sneakers#414) to pass the worker itself to middleware. Until that is merged I don't think there's a way to get the worker name for the transaction names. Too bad, and we fall back on the queue name.

@estolfo, how do you feel about marking Sneakers support as experimental until a way to get the worker name is provided? That way we won't need to do the whole version dance around breaking changes when we change the names of all Sneakers transactions?

@zube zube bot removed this from the 7.6 milestone Jan 8, 2020
@estolfo
Copy link
Contributor

estolfo commented Jan 8, 2020

I think there's no harm in making it experimental for now. But I would also write a comment on the Sneakers PR you referenced to let them know you're hoping that it'll be merged soon. That seemed to work for this jondot/sneakers#367

@codecov-io
Copy link

codecov-io commented Jan 8, 2020

Codecov Report

Merging #676 into master will increase coverage by 31.04%.
The diff coverage is 92.3%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #676       +/-   ##
===========================================
+ Coverage   64.11%   95.16%   +31.04%     
===========================================
  Files          99      103        +4     
  Lines        2943     3205      +262     
===========================================
+ Hits         1887     3050     +1163     
+ Misses       1056      155      -901
Impacted Files Coverage Δ
lib/elastic_apm/config.rb 84.31% <ø> (+9.8%) ⬆️
lib/elastic_apm/spies/sneakers.rb 92.3% <92.3%> (ø)
lib/elastic_apm/spies/json.rb
lib/elastic_apm/sql/signature.rb 98.63% <0%> (ø)
lib/elastic_apm/sql/tokenizer.rb 99.24% <0%> (ø)
lib/elastic_apm/sql/tokens.rb 100% <0%> (ø)
lib/elastic_apm/sql_summarizer.rb 100% <0%> (ø)
lib/elastic_apm/metrics.rb 94.64% <0%> (+3.57%) ⬆️
lib/elastic_apm/metrics/cpu_mem_set.rb 97.95% <0%> (+4.08%) ⬆️
... and 74 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d78f91...56a386a. Read the comment docs.

Copy link
Contributor

@estolfo estolfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a minor version mistake in the docs

Gemfile Outdated Show resolved Hide resolved
docs/supported-technologies.asciidoc Outdated Show resolved Hide resolved
Gemfile Outdated Show resolved Hide resolved
docs/supported-technologies.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@estolfo estolfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another minor comment

Gemfile Outdated Show resolved Hide resolved
Co-Authored-By: Emily S <emily.s@elastic.co>
@mikker mikker requested a review from estolfo January 8, 2020 14:28
@mikker mikker merged commit 38c0c4f into elastic:master Jan 9, 2020
@mikker mikker deleted the redwrx-sneakers_support branch January 9, 2020 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants