Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request Per Minute [APM] visualization uses wrong field #214

Closed
jjfalling opened this issue Sep 29, 2017 · 5 comments · Fixed by #226
Closed

Request Per Minute [APM] visualization uses wrong field #214

jjfalling opened this issue Sep 29, 2017 · 5 comments · Fixed by #226
Assignees

Comments

@jjfalling
Copy link

Request Per Minute [APM] should use transaction.result as the filter field for the status code (or APM is sending the wrong field ;) )

@watson
Copy link
Contributor

watson commented Sep 30, 2017

Yes, I think you're right. The dashboards are probably using context.response.status_code at the moment. This field might not always be present (whereas transaction.result should be).

The transaction.result field is a string and there's no rule that it should conform to look like an HTTP status code.

Also, even if the two fields are both present, there's no guarantee that they are the same. I think we even discussed if transaction.result - in case of an incoming http request - should be converted from the string 200 to 2xx already in the agent instead of when viewed in Kibana?

@simitt
Copy link
Contributor

simitt commented Oct 11, 2017

@beniwohli and @watson what do you think about making transaction.result a mandatory field? This way we could always rely on this field for visualizations.

@beniwohli
Copy link
Contributor

I'm ok with that!

@watson
Copy link
Contributor

watson commented Oct 11, 2017

Sounds like a good idea 👍

@simitt
Copy link
Contributor

simitt commented Oct 13, 2017

Thank you @jjfalling for bringing this up, we changed the dashboards to use transaction.result now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants