Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action: lint is mandatory but doc changes don't need it (backport #10564) #10569

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 30, 2023

This is an automatic backport of pull request #10564 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@kruskall
Copy link
Member

cc @bmorelli25

@apmmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-30T14:54:59.120+0000

  • Duration: 7 min 43 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate and publish the docker images.

  • /test windows : Build & tests on Windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@apmmachine
Copy link
Collaborator

📚 Go benchmark report

Diff with the 8.7 branch

goos: linux
goarch: amd64
pkg: github.com/elastic/apm-server/internal/agentcfg
cpu: 12th Gen Intel(R) Core(TM) i5-12500
                                  │ build/8.7/bench.out │              bench.out              │
                                  │       sec/op        │    sec/op     vs base               │
FetchAndAdd/FetchFromCache-12              46.09n ± ∞ ¹   41.13n ± ∞ ¹  -10.76% (p=0.008 n=5)
FetchAndAdd/FetchAndAddToCache-12         102.10n ± ∞ ¹   94.12n ± ∞ ¹   -7.82% (p=0.008 n=5)
geomean                                    68.60n         62.22n         -9.30%
¹ need >= 6 samples for confidence interval at level 0.95

                                  │ build/8.7/bench.out │              bench.out              │
                                  │        B/op         │    B/op      vs base                │
geomean                                               ³                +0.00%               ³
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal
³ summaries must be >0 to compute geomean

                                  │ build/8.7/bench.out │              bench.out              │
                                  │      allocs/op      │  allocs/op   vs base                │
geomean                                               ³                +0.00%               ³
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal
³ summaries must be >0 to compute geomean

pkg: github.com/elastic/apm-server/internal/beater/request
                                             │ build/8.7/bench.out │              bench.out              │
                                             │       sec/op        │    sec/op     vs base               │
ContextReset/Forwarded_ipv4-12                        870.4n ± ∞ ¹   588.2n ± ∞ ¹  -32.42% (p=0.016 n=5)
ContextResetContentEncoding/empty-12                  135.9n ± ∞ ¹   121.4n ± ∞ ¹  -10.67% (p=0.008 n=5)
ContextResetContentEncoding/uncompressed-12           161.0n ± ∞ ¹   143.9n ± ∞ ¹  -10.62% (p=0.008 n=5)
geomean                                               964.8n         910.9n         -5.58%
¹ need >= 6 samples for confidence interval at level 0.95

                                             │ build/8.7/bench.out │               bench.out               │
                                             │        B/op         │     B/op       vs base                │
geomean                                                          ³                  +0.00%               ³
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal
³ summaries must be >0 to compute geomean

                                             │ build/8.7/bench.out │              bench.out              │
                                             │      allocs/op      │  allocs/op   vs base                │
geomean                                                          ³                +0.00%               ³
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal
³ summaries must be >0 to compute geomean

pkg: github.com/elastic/apm-server/internal/publish
             │ build/8.7/bench.out │          bench.out           │
             │       sec/op        │   sec/op     vs base         │
¹ need >= 6 samples for confidence interval at level 0.95

             │ build/8.7/bench.out │           bench.out            │
             │        B/op         │     B/op       vs base         │
¹ need >= 6 samples for confidence interval at level 0.95

             │ build/8.7/bench.out │           bench.out           │
             │      allocs/op      │  allocs/op    vs base         │
¹ need >= 6 samples for confidence interval at level 0.95

pkg: github.com/elastic/apm-server/x-pack/apm-server/aggregation/spanmetrics
                 │ build/8.7/bench.out │           bench.out           │
                 │       sec/op        │    sec/op     vs base         │
¹ need >= 6 samples for confidence interval at level 0.95

                 │ build/8.7/bench.out │            bench.out             │
                 │        B/op         │     B/op       vs base           │
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal

                 │ build/8.7/bench.out │           bench.out            │
                 │      allocs/op      │  allocs/op   vs base           │
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal

pkg: github.com/elastic/apm-server/x-pack/apm-server/aggregation/txmetrics
                        │ build/8.7/bench.out │           bench.out           │
                        │       sec/op        │    sec/op     vs base         │
¹ need >= 6 samples for confidence interval at level 0.95

                        │ build/8.7/bench.out │           bench.out            │
                        │        B/op         │    B/op      vs base           │
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal

                        │ build/8.7/bench.out │           bench.out            │
                        │      allocs/op      │  allocs/op   vs base           │
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal

pkg: github.com/elastic/apm-server/x-pack/apm-server/sampling
               │ build/8.7/bench.out │             bench.out              │
               │       sec/op        │    sec/op     vs base              │
geomean                 624.6n         584.4n        -6.43%
¹ need >= 6 samples for confidence interval at level 0.95

               │ build/8.7/bench.out │               bench.out               │
               │        B/op         │     B/op       vs base                │
geomean                            ³                  -0.43%               ³
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal
³ summaries must be >0 to compute geomean

               │ build/8.7/bench.out │              bench.out              │
               │      allocs/op      │  allocs/op   vs base                │
geomean                            ³                +0.00%               ³
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal
³ summaries must be >0 to compute geomean

pkg: github.com/elastic/apm-server/x-pack/apm-server/sampling/eventstorage
                                            │ build/8.7/bench.out │              bench.out              │
                                            │       sec/op        │    sec/op     vs base               │
WriteTransaction/json_codec-12                      12.542µ ± ∞ ¹   4.400µ ± ∞ ¹  -64.92% (p=0.008 n=5)
WriteTransaction/json_codec_big_tx-12               10.293µ ± ∞ ¹   4.909µ ± ∞ ¹  -52.31% (p=0.008 n=5)
ReadEvents/json_codec/0_events-12                    359.2n ± ∞ ¹   303.6n ± ∞ ¹  -15.48% (p=0.008 n=5)
ReadEvents/json_codec_big_tx/0_events-12             349.8n ± ∞ ¹   308.4n ± ∞ ¹  -11.84% (p=0.008 n=5)
ReadEvents/json_codec_big_tx/1_events-12             12.68µ ± ∞ ¹   12.00µ ± ∞ ¹   -5.35% (p=0.032 n=5)
ReadEvents/nop_codec/0_events-12                     351.0n ± ∞ ¹   309.3n ± ∞ ¹  -11.88% (p=0.008 n=5)
ReadEvents/nop_codec_big_tx/0_events-12              344.0n ± ∞ ¹   301.9n ± ∞ ¹  -12.24% (p=0.032 n=5)
IsTraceSampled/sampled-12                            76.04n ± ∞ ¹   69.43n ± ∞ ¹   -8.69% (p=0.008 n=5)
IsTraceSampled/unsampled-12                          79.01n ± ∞ ¹   71.26n ± ∞ ¹   -9.81% (p=0.008 n=5)
IsTraceSampled/unknown-12                            433.3n ± ∞ ¹   380.3n ± ∞ ¹  -12.23% (p=0.008 n=5)
geomean                                              31.38µ         28.91µ         -7.87%
¹ need >= 6 samples for confidence interval at level 0.95

                                            │ build/8.7/bench.out │               bench.out                │
                                            │        B/op         │      B/op       vs base                │
WriteTransaction/json_codec_big_tx-12               3.687Ki ± ∞ ¹    3.686Ki ± ∞ ¹  -0.03% (p=0.032 n=5)
geomean                                             31.39Ki          31.46Ki        +0.23%
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal

                                            │ build/8.7/bench.out │              bench.out               │
                                            │      allocs/op      │  allocs/op    vs base                │
geomean                                               144.7          144.7        +0.00%
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal

report generated with https://pkg.go.dev/golang.org/x/perf/cmd/benchstat

@bmorelli25
Copy link
Member

Thank you, @kruskall! I think backporting via mergify is still blocked though. I'm going to close this and cherry-pick the commit so we can merge.

@bmorelli25 bmorelli25 closed this Mar 30, 2023
@bmorelli25 bmorelli25 deleted the mergify/bp/8.7/pr-10564 branch March 30, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants