Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildkite(dra): support list for feature branches #13139

Merged
merged 5 commits into from
May 24, 2024

Conversation

v1v
Copy link
Member

@v1v v1v commented May 10, 2024

Motivation/summary

Support feature branches to list DRA artifacts, since #13001 introduced a regression when working on a feature branch.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

@v1v v1v added backport-7.17 Automated backport with mergify to the 7.17 branch backport-8.14 Automated backport with mergify labels May 10, 2024
@v1v v1v self-assigned this May 10, 2024
@v1v v1v marked this pull request as ready for review May 10, 2024 12:10
@v1v v1v requested a review from a team as a code owner May 10, 2024 12:10
@v1v v1v requested a review from a team May 10, 2024 12:10
reakaleek
reakaleek previously approved these changes May 14, 2024
@v1v v1v enabled auto-merge (squash) May 15, 2024 16:42
.buildkite/scripts/dra.sh Outdated Show resolved Hide resolved
.buildkite/scripts/dra.sh Outdated Show resolved Hide resolved
@v1v
Copy link
Member Author

v1v commented May 23, 2024

This will help while working on #13137 and the different follow-ups.

For instance, I detected at the very last moment that my changes would produce a failure when merged since the DRA in Buildktie will require a docker login. Unfortunately, I could not detect it until the very end when I found that I didn't change the Buildkite pipeline to run some docker login.

Therefore, if possible, I'd ask for some reviews 🙏

@v1v v1v merged commit fff236c into main May 24, 2024
10 checks passed
@v1v v1v deleted the feature/support-feature-branch-dra branch May 24, 2024 10:37
mergify bot pushed a commit that referenced this pull request May 24, 2024
(cherry picked from commit fff236c)

# Conflicts:
#	.buildkite/scripts/dra.sh
mergify bot pushed a commit that referenced this pull request May 24, 2024
mergify bot added a commit that referenced this pull request May 24, 2024
(cherry picked from commit fff236c)

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
v1v added a commit to v1v/apm-server that referenced this pull request May 27, 2024
…impler

* upstream/main: (28 commits)
  chore: Update to elastic/beats@19499ae5ab94 (elastic#13240)
  [updatecli] Bump elastic stack version to 8.15.0-561c6014 (elastic#13241)
  buildkite: create chainguard images (elastic#13226)
  chore: Update to elastic/beats@d5bfebb8940d (elastic#13231)
  [updatecli] Bump elastic stack version to 8.15.0-04e5793a (elastic#13227)
  build and push Docker image based on Chainguard base image (elastic#13137)
  buildkite(dra): support list for feature branches (elastic#13139)
  [updatecli] Bump elastic stack version to 8.15.0-e7873a67 (elastic#13218)
  chore: Update to elastic/beats@2419622b1b33 (elastic#13220)
  build(deps): bump the otel group with 3 updates (elastic#13213)
  [updatecli] Bump elastic stack version to 8.15.0-21ea2af3 (elastic#13206)
  chore: Update to elastic/beats@4a670391a6e2 (elastic#13209)
  build(deps): bump github.com/open-telemetry/opentelemetry-collector-contrib/pkg/translator/jaeger from 0.100.0 to 0.101.0 in the jaeger group (elastic#13214)
  build(deps): bump the otel group with 2 updates (elastic#13205)
  Depend on apm-data plugin (elastic#12066)
  chore: Update to elastic/beats@d8072923498c (elastic#13203)
  [updatecli] Bump elastic stack version to 8.15.0-9bce1e63 (elastic#13200)
  build(deps): bump github.com/elastic/elastic-agent-system-metrics from 0.10.1 to 0.10.2 (elastic#13195)
  chore: Update to elastic/beats@062cc9b191b5 (elastic#13190)
  [updatecli] Bump elastic stack version to 8.15.0-1a872dbc (elastic#13185)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.17 Automated backport with mergify to the 7.17 branch backport-8.14 Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants