apmpackage: add more elasticsearch privileges #6139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
1 task
axw
force-pushed
the
apmpackage-elasticsearch-privileges
branch
2 times, most recently
from
b09bc14
to
221aacf
Compare
axw
force-pushed
the
apmpackage-elasticsearch-privileges
branch
from
221aacf
to
5335626
Compare
axw
commented
Oct 6, 2021
Comment on lines
+492
to
+493
| vcsRefShort := vcsRef[:6] | ||
| apmServerInstallDir := fmt.Sprintf("./data/elastic-agent-%s/install/apm-server-%s-linux-%s", vcsRefShort, stackVersion, arch) |
There was a problem hiding this comment.
there were some changes to elastic-agent which meant we haven't been running with the custom, injected apm-server binary.
|
/test |
marclop
reviewed
Oct 6, 2021
|
Moving this back into draft as I look into the test failures. Seems to be some kind of test isolation issue. |
We now only install the integration once before running all the tests. We uninstall any existing apm package, which will take care of removing outdated integration index templates.
|
/test |
simitt
approved these changes
Oct 12, 2021
Co-authored-by: Silvia Mitter <silvia.mitter@elastic.co>
mergify bot
pushed a commit
that referenced
this pull request
Oct 12, 2021
* tools: upgrade elastic-package * apmpackage: add privileges for sampled_traces * apmpackage: add config vars for tail sampling * apmpackage: update changelog * systemtest: test tail-sampling with Fleet * systemtest: don't delete integration templates We now only install the integration once before running all the tests. We uninstall any existing apm package, which will take care of removing outdated integration index templates. * Update systemtest/fleet_test.go Co-authored-by: Silvia Mitter <silvia.mitter@elastic.co> Co-authored-by: Silvia Mitter <silvia.mitter@elastic.co> (cherry picked from commit fa65ccc)
axw
added a commit
that referenced
this pull request
Oct 12, 2021
* tools: upgrade elastic-package * apmpackage: add privileges for sampled_traces * apmpackage: add config vars for tail sampling * apmpackage: update changelog * systemtest: test tail-sampling with Fleet * systemtest: don't delete integration templates We now only install the integration once before running all the tests. We uninstall any existing apm package, which will take care of removing outdated integration index templates. * Update systemtest/fleet_test.go Co-authored-by: Silvia Mitter <silvia.mitter@elastic.co> Co-authored-by: Silvia Mitter <silvia.mitter@elastic.co> (cherry picked from commit fa65ccc) Co-authored-by: Andrew Wilkins <axw@elastic.co>
marclop
added
backport-skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Add privileges to the sampled traces data stream in order to refresh indices, querying index stats, and read documents. This data stream holds only non-sensitive information.
Introduce config vars to the integration package for tail-sampling. These are used in a revised system test, which now uses the Fleet integration.
Checklist
- [ ] Documentation has been updatedHow to test these changes
Can't be manually tested yet, needs UI for configuring tail-sampling policies.
Related issues
Closes #5490