-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java attacher runs only in non-cloud environments #6617
Java attacher runs only in non-cloud environments #6617
Conversation
This pull request does not have a backport label. Could you fix it @stuartnelson3? 🙏
NOTE: |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
/test |
@felixbarny would you be able to test this? the docker container doesn't contain the java runtime so the attacher errors out, but either building a tarball or running |
We have a dedicated task to test the attachment end-to-end: elastic/apm-agent-java#2196. I think it makes sense to start that after #4830 is closed. Sub-tasks like these can tested and reviewed in isolation as good as possible. I think the testing phase can start in parallel with the UI implementation. After the UI is done, there'll be a second QA phase that tests fully end-to-end. WDYT? |
Sounds good to me, will merge once tests pass |
/test |
(cherry picked from commit fb55a38)
Verified with cdeec66: {"log.level":"error","@timestamp":"2022-01-04T15:41:28.521+0800","log.logger":"beater","log.origin":{"file.name":"beater/beater.go","file.line":443},"message":"java attacher not supported in cloud environments","service.name":"apm-server","ecs.version":"1.6.0"} |
Motivation/summary
start the java attacher jar only when running in a non-cloud environment
Checklist
How to test these changes
ELASTIC_AGENT_CLOUD
set in the environmentELASTIC_AGENT_CLOUD
NOT set in the environmentRelated issues
requested in #5479
depends on #6593