Skip to content

Commit

Permalink
Remove setup deprecation message (#4889) (#4926)
Browse files Browse the repository at this point in the history
* Unmark setup as deprecated

We decided to keep `-setup` as a shorthand for setup + run

* Update `test output` help message

(cherry picked from commit 8bc9c80)
  • Loading branch information
exekias authored and andrewkroh committed Aug 16, 2017
1 parent c46428d commit df42f67
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 7 deletions.
4 changes: 0 additions & 4 deletions libbeat/beat/beat.go
Expand Up @@ -298,10 +298,6 @@ func (b *Beat) launch(bt Creator) error {

svc.HandleSignals(beater.Stop)

// TODO Deprecate this in favor of setup subcommand (7.0)
if *setup {
cfgwarn.Deprecate("6.0", "-setup flag has been deprectad, use setup subcommand")
}
err = b.loadDashboards(false)
if err != nil {
return err
Expand Down
3 changes: 1 addition & 2 deletions libbeat/cmd/run.go
Expand Up @@ -30,11 +30,10 @@ func genRunCmd(name, version string, beatCreator beat.Creator, runFlags *pflag.F

// TODO deprecate in favor of subcommands (7.0):
runCmd.Flags().AddGoFlag(flag.CommandLine.Lookup("configtest"))
runCmd.Flags().AddGoFlag(flag.CommandLine.Lookup("setup"))
runCmd.Flags().AddGoFlag(flag.CommandLine.Lookup("version"))

runCmd.Flags().MarkDeprecated("version", "version flag has been deprectad, use version subcommand")
runCmd.Flags().MarkDeprecated("configtest", "setup flag has been deprectad, use configtest subcommand")
runCmd.Flags().MarkDeprecated("configtest", "configtest flag has been deprectad, use test config subcommand")

if runFlags != nil {
runCmd.Flags().AddFlagSet(runFlags)
Expand Down
2 changes: 1 addition & 1 deletion libbeat/cmd/test/output.go
Expand Up @@ -14,7 +14,7 @@ import (
func GenTestOutputCmd(name, beatVersion string) *cobra.Command {
return &cobra.Command{
Use: "output",
Short: "Test output works with current settings",
Short: "Test " + name + " can connect to the output by using the current settings",
Run: func(cmd *cobra.Command, args []string) {
b, err := beat.New(name, beatVersion)
if err != nil {
Expand Down

0 comments on commit df42f67

Please sign in to comment.