Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Heartbeat] Add tag based filtering support when running synthetic monitors #26747

Closed
vigneshshanmugam opened this issue Jul 6, 2021 · 5 comments · Fixed by #27347
Closed
Assignees
Labels
enhancement Team:obs-ds-hosted-services Label for the Observability Hosted Services team test-plan-ok This PR passed manual testing v7.15.0

Comments

@vigneshshanmugam
Copy link
Member

vigneshshanmugam commented Jul 6, 2021

Describe the enhancement:

The synthetics agent already supports both tags based filtering via the --tags tag-a, tag-b and other glob based filtering via --match. We need the same capability like how tags are used in ICMP based monitors and extend it to the synthetic monitors.

- type: browser
  id: browser-inline
  filter_journeys: 
    tags: ["home", "app"]
    match: "foo"
  name: browser-inline
  schedule: "@every 1m"

These applied tags would then be mapped under each monitor on the Kibana Uptime UI.

@vigneshshanmugam vigneshshanmugam added enhancement Team:obs-ds-hosted-services Label for the Observability Hosted Services team v7.15.0 labels Jul 6, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@paulb-elastic
Copy link
Contributor

@vigneshshanmugam does anything else need doing here?

If I add a tag for a browser test with tags: ["testTag1", "testTag2"] for example, I do see these in Uptime:

image

@vigneshshanmugam
Copy link
Member Author

@paulb-elastic We need to make sure these tags are sent to the Synthetics CLI to make use of the filtering logic which is essential for big projects like Kibana. We need to enable this - elastic/synthetics#300

@vigneshshanmugam vigneshshanmugam changed the title [Heartbeat] Add tags support when running synthetic monitors [Heartbeat] Add tag based filtering support when running synthetic monitors Aug 12, 2021
@vigneshshanmugam
Copy link
Member Author

@paulb-elastic I see the confusion, After discussion with Andrew, I have updated the description and moved the tags under filter_journey option.

@vigneshshanmugam vigneshshanmugam self-assigned this Aug 12, 2021
@zube zube bot added [zube]: Done and removed [zube]: Ready labels Aug 16, 2021
@vigneshshanmugam vigneshshanmugam removed their assignment Aug 18, 2021
@vigneshshanmugam vigneshshanmugam added the test-plan Add this PR to be manual test plan label Aug 18, 2021
@dominiqueclarke dominiqueclarke self-assigned this Aug 23, 2021
@dominiqueclarke dominiqueclarke added test-plan-ok This PR passed manual testing and removed test-plan Add this PR to be manual test plan labels Aug 23, 2021
@dominiqueclarke
Copy link

dominiqueclarke commented Aug 23, 2021

Works as expected with both tags and match. Tested against beats 7.15 branch with synthetics 1.0.0-beta.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Team:obs-ds-hosted-services Label for the Observability Hosted Services team test-plan-ok This PR passed manual testing v7.15.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants