Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove erroneous coercion of user/group ID in Filebeat system.auth #10233

Merged
merged 2 commits into from
Jan 23, 2019
Merged

Remove erroneous coercion of user/group ID in Filebeat system.auth #10233

merged 2 commits into from
Jan 23, 2019

Conversation

webmat
Copy link
Contributor

@webmat webmat commented Jan 21, 2019

IDs should be keyword.

@webmat webmat requested a review from a team as a code owner January 21, 2019 21:33
@webmat webmat self-assigned this Jan 21, 2019
@webmat
Copy link
Contributor Author

webmat commented Jan 21, 2019

Question: this has only been released in 7.0.0-alpha2. Does this require a changelog nonetheless?

@webmat webmat added the review label Jan 21, 2019
@webmat webmat requested a review from ruflin January 21, 2019 21:35
ruflin
ruflin approved these changes Jan 22, 2019
View reviewed changes
Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I would still add a changelog entry. We will clean them up for the final release.

@webmat
Copy link
Contributor Author

webmat commented Jan 23, 2019

Changelog added. Pretty straightforward. Merging now, let me know if not satisfactory.

@webmat webmat merged commit a56ee81 into elastic:master Jan 23, 2019
@webmat webmat deleted the ecs-incorrect-uid-coercions branch January 23, 2019 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

Assignees

@webmat webmat

Labels
ecs Filebeat Filebeat module review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@webmat @ruflin