Continuation of #8561 - add windows.service.start_name and windows.service.path_name #11877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd usename of service
…callaha-issue-8364 Resolve conflicts
narph
added
Team:Integrations
ruflin
approved these changes
Apr 23, 2019
There was a problem hiding this comment.
LGTM except for the Changelog.
@andrewkroh Could you take a look?
|
jenkins, test this |
ruflin
approved these changes
Apr 24, 2019
andrewkroh
approved these changes
Apr 24, 2019
|
jenkins, test this |
ruflin
approved these changes
Apr 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing conflicts for #8561 in order to get the PR in.