Teach elasticsearch/slowlog fileset to parse more fields #11939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycombinator
added
in progress
ycombinator
changed the title
ycombinator
changed the title
ycombinator
force-pushed
the
fb-es-slowlog-structured-new-fields
branch
from
a24aea9
to
1734efd
Compare
cachedout
approved these changes
Jun 25, 2019
ycombinator
changed the title
cachedout
approved these changes
Jun 26, 2019
pgomulka
reviewed
Jun 26, 2019
| @@ -87,6 +87,27 @@ | |||
| "ignore_missing": true | |||
| } | |||
| }, | |||
| { | |||
| "rename": { | |||
There was a problem hiding this comment.
is this going to work if we remove that field in 8? (I have remove that so possibly there this probably will be empty/missing). I forgot about that in my PR, fixing now
There was a problem hiding this comment.
Yes, it should be okay because of the ignore_missing flag set on this processor (see a couple lines below). In 9 we can completely remove this processor from the pipeline as, by then we won't expect to see any log lines with doc_type in them.
ycombinator
force-pushed
the
fb-es-slowlog-structured-new-fields
branch
from
db06e97
to
cb3b07d
Compare
ycombinator
force-pushed
the
fb-es-slowlog-structured-new-fields
branch
from
cb3b07d
to
483242b
Compare
ycombinator
removed
the
needs_backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR teaches the
elasticsearch/slowlogfileset to parse additional fields. These additional fields are introduced in elastic/elasticsearch#41354.