Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional fields to MySQL module #12227

Merged
merged 10 commits into from
May 28, 2019
Merged

Additional fields to MySQL module #12227

merged 10 commits into from
May 28, 2019

Conversation

aidarbek
Copy link
Contributor

@aidarbek aidarbek commented May 21, 2019 •
edited by andresrc

Fixes #12088

@aidarbek aidarbek requested a review from a team as a code owner May 21, 2019 17:40
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@ph ph added the review label May 23, 2019
@ruflin ruflin added the Team:Integrations Label for the Integrations team label May 23, 2019
@aidarbek aidarbek requested a review from a team as a code owner May 23, 2019 13:24
jsoriano
jsoriano reviewed May 24, 2019
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition, thanks!
@aidarbek, could you regenerate the data.json file for the status metricset so it shows the new metrics? You can do it by running go test -tags=integration ./metricbeat/module/mysql/status -data. If you have any problem with that I am happy to do it myself in a follow up PR.

metricbeat/mb/testing/data/data_test.go Outdated Show resolved Hide resolved
@aidarbek
Copy link
Contributor Author

Hi @jsoriano, thanks for feedback. I thought that data.json should be changed as well, but didn't know the command and was too lazy to do it manually :)
I've made changes using my local MySQL database. Hope it will work

@jsoriano
Copy link
Member

Thanks! It looks great.

@jsoriano
Copy link
Member

jenkins, test this please

@jsoriano
Copy link
Member

Jenkins, test this again please

jsoriano
jsoriano approved these changes May 24, 2019
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for green

@aidarbek
Copy link
Contributor Author

@jsoriano could you merge it, if everything is OK? :)

@jsoriano jsoriano merged commit af5afd2 into elastic:master May 28, 2019
@jsoriano
Copy link
Member

Thanks @aidarbek! Great work here 🙂

@Cho1409
Copy link

Cho1409 commented Jun 24, 2019

@jsoriano Excuse me but, Is it live yet? I'm not sure if we need to wait for a specific release of the beats package or something.

@jsoriano
Copy link
Member

@Cho1409 this change will be released on Metricbeat 7.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng left review comments

@jsoriano jsoriano jsoriano approved these changes

Assignees

@jsoriano jsoriano

@aidarbek aidarbek

Labels
review Team:Integrations Label for the Integrations team v7.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add additional fields to MySQL module
7 participants
@aidarbek @elasticmachine @jsoriano @Cho1409 @kaiyan-sheng @ph @ruflin