-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport #12284 to 7.2: Import ECS 1.0.1 #12299
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just realised we didn't update the Golang code dependency. This means internally we still report ECS version 1.0 instead of 1.0.1.
@ruflin I'm confused. What does this have to do with this PR? :-) |
Ah you mean the Golang generated code. You're right. 🤦♂ |
I won't have time to pick that up. A Beats dev should do that part. |
I think it's important that we ship both at the same time (single PR) as otherwise we have an inconsistency between definition and what we ship as part of each event. @cwurm Could you pick this up? We also must fix "master" as it slipped through there. |
@ruflin Agreed. |
PR for fixing it in master: #12317 |
This didn't make it. Closing |
Backport of #12284 to 7.2. Original message:
This is a patch release of ECS, as it only contains minor fixes, mostly field formatting, and examples for a few fields. No new fields in this release.
The killer feature of ECS 1.0.1 is elastic/ecs#454. This change will make pivoting around numeric values such as port numbers & PIDs much more streamlined, as it will prevent Kibana from adding thousands separators.
I'm hoping we can backport this to 7.2, as I think it fits really well with the introduction of the SIEM app.