Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert timezones if event.timezone is set #12311

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented May 28, 2019

Follow up of #12253

@jsoriano jsoriano added review Filebeat Filebeat [zube]: In Review Team:Integrations Label for the Integrations team labels May 28, 2019
@jsoriano jsoriano requested review from a team as code owners May 28, 2019 11:38
@jsoriano jsoriano self-assigned this May 28, 2019
@jsoriano jsoriano requested a review from a team May 28, 2019 11:38
Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to stack modules look good to me. Thanks @jsoriano! ❤️

Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM. I know wonder if we need to update the docs in some places as the conver_timezone config becomes obsolete?

@jsoriano
Copy link
Member Author

Change LGTM. I know wonder if we need to update the docs in some places as the conver_timezone config becomes obsolete?

@ruflin It doesn't become obsolete yet, it is still used in filebeat to decide if event.timezone is set.

@ruflin
Copy link
Member

ruflin commented May 29, 2019

@jsoriano Got it.

BTW I found a way where this could be a breaking change: For whatever reason without enabling convert_timezone the user had event.timezone field set. So not it starts converting. But I don't expect that this is an edge case we will hit so we should move forward here.

@jsoriano
Copy link
Member Author

@ruflin looking for what could be setting the event.timezone field, I have found that the PosgreSQL module was parsing it from the logs, but not using it to parse the date, I have opened a separate PR for this: #12338
Do you know of other cases where event.timezone is set?
In any case take into account that timezone conversion using the timezone of the machine (in the event.timezone field) is only done in modules whose logs don't include a timezone.

@ruflin
Copy link
Member

ruflin commented May 29, 2019

@jsoriano Not that I'm aware of. In any case, let's move forward with this PR.

@jsoriano jsoriano merged commit 3af1f29 into elastic:master May 29, 2019
@jsoriano jsoriano deleted the convert-timezone-conditional-template-follow-up branch May 29, 2019 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Filebeat Filebeat review Team:Integrations Label for the Integrations team v7.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants