-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert timezones if event.timezone is set #12311
Convert timezones if event.timezone is set #12311
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes to stack modules look good to me. Thanks @jsoriano! ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change LGTM. I know wonder if we need to update the docs in some places as the conver_timezone
config becomes obsolete?
@ruflin It doesn't become obsolete yet, it is still used in filebeat to decide if |
@jsoriano Got it. BTW I found a way where this could be a breaking change: For whatever reason without enabling |
@ruflin looking for what could be setting the |
@jsoriano Not that I'm aware of. In any case, let's move forward with this PR. |
Follow up of #12253