-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse the timezone in PostgreSQL logs as part of the date #12338
Conversation
Parse the timezone in PostgreSQL logs as part of the date.
6e6c48f
to
ba6de6a
Compare
@@ -1,6 +1,6 @@ | |||
[ | |||
{ | |||
"@timestamp": "2017-07-31T13:36:42.585Z", | |||
"@timestamp": "2017-07-31T11:36:42.585Z", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means we had previously a bug in here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say so, yes. It was not using the timezone for date parsing before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, labeled PR as a bug 👍
filebeat/module/postgresql/log/test/postgresql-9.6-debian-with-slowlog.log-expected.json
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Would be good to have a deprecated note in the changelog for the deprecated field.
Timezone in PostgreSQL logs is being parsed in a separated
field but then it is not being used for the final timestamp. Parse it
as part of the whole timestamp.