Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse the timezone in PostgreSQL logs as part of the date #12338

Merged
merged 5 commits into from
Jun 3, 2019

Conversation

jsoriano
Copy link
Member

Timezone in PostgreSQL logs is being parsed in a separated
field but then it is not being used for the final timestamp. Parse it
as part of the whole timestamp.

@jsoriano jsoriano requested a review from a team as a code owner May 29, 2019 10:31
@jsoriano jsoriano self-assigned this May 29, 2019
Parse the timezone in PostgreSQL logs as part of the date.
@@ -1,6 +1,6 @@
[
{
"@timestamp": "2017-07-31T13:36:42.585Z",
"@timestamp": "2017-07-31T11:36:42.585Z",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means we had previously a bug in here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say so, yes. It was not using the timezone for date parsing before.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, labeled PR as a bug 👍

@jsoriano jsoriano requested a review from a team as a code owner May 29, 2019 14:42
@ruflin ruflin added the bug label Jun 3, 2019
Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would be good to have a deprecated note in the changelog for the deprecated field.

@jsoriano jsoriano merged commit 562bcfa into elastic:master Jun 3, 2019
@jsoriano jsoriano deleted the postgresql-date-timezone branch June 3, 2019 23:35
andrewvc pushed a commit to andrewvc/beats that referenced this pull request Jun 12, 2019
)

Timezone in PostgreSQL logs is being parsed in a separated
field but then it is not being used for the final timestamp. Parse it
as part of the whole timestamp.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants