Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metricbeat]Add kubeproxy dashboard #12734

Merged
merged 6 commits into from
Jul 4, 2019

Conversation

odacremolbap
Copy link
Contributor

Add kubernetes proxy dashboard

Dependent on #12728

@odacremolbap odacremolbap requested a review from a team as a code owner July 1, 2019 13:27
@odacremolbap odacremolbap added Team:Integrations Label for the Integrations team containers Related to containers use case Metricbeat Metricbeat labels Jul 1, 2019
@odacremolbap odacremolbap self-assigned this Jul 1, 2019
@exekias
Copy link
Contributor

exekias commented Jul 1, 2019

Could you share a screenshot of the dashboard? it would also be awesome to show it in the docs, by adding the file to https://github.com/elastic/beats/tree/master/metricbeat/docs/images and a section to docs, like: https://raw.githubusercontent.com/elastic/beats/master/metricbeat/module/apache/_meta/docs.asciidoc

@odacremolbap
Copy link
Contributor Author

image

image

@odacremolbap
Copy link
Contributor Author

re Docs: I'll wait for the kube-controller-manager and kube-scheduler to select the more appealing screenshot

@exekias
Copy link
Contributor

exekias commented Jul 1, 2019

I'm ok with having it done later, as it's a docs change 👍

Just a note, you can add all of them!, as there is a page per metricset.

@exekias
Copy link
Contributor

exekias commented Jul 1, 2019

CI failure looks related to dashboards

@odacremolbap
Copy link
Contributor Author

yes, working on it

@odacremolbap
Copy link
Contributor Author

jenkins, test this

@odacremolbap odacremolbap added the in progress Pull request is currently in progress. label Jul 1, 2019
Copy link
Contributor

@exekias exekias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is happy

@odacremolbap odacremolbap added review and removed in progress Pull request is currently in progress. labels Jul 3, 2019
@odacremolbap odacremolbap requested a review from exekias July 3, 2019 11:56
@odacremolbap odacremolbap requested a review from a team as a code owner July 3, 2019 17:39
@sayden sayden self-requested a review July 4, 2019 07:58
@sayden
Copy link
Contributor

sayden commented Jul 4, 2019

Tested locally
image

@odacremolbap odacremolbap merged commit 6fac2f7 into elastic:master Jul 4, 2019
@odacremolbap odacremolbap deleted the task/kubeproxy-dashboard branch July 4, 2019 09:15
@exekias exekias added the needs_backport PR is waiting to be backported to other branches. label Jul 4, 2019
odacremolbap pushed a commit to odacremolbap/beats that referenced this pull request Jul 4, 2019
* add kubeproxy dashboard


(cherry picked from commit 6fac2f7)
odacremolbap pushed a commit that referenced this pull request Jul 4, 2019
* add kubeproxy dashboard


(cherry picked from commit 6fac2f7)
@jsoriano jsoriano removed the needs_backport PR is waiting to be backported to other branches. label Aug 29, 2019
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
* add kubeproxy dashboard


(cherry picked from commit 82cbc2f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
containers Related to containers use case Metricbeat Metricbeat review Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants