Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metricbeat] Add Tablespaces dashboard to Oracle module #12736

Merged
merged 3 commits into from
Jul 4, 2019
Merged

[Metricbeat] Add Tablespaces dashboard to Oracle module #12736

merged 3 commits into from
Jul 4, 2019

Conversation

sayden
Copy link
Contributor

@sayden sayden commented Jul 1, 2019

image

It only contains data from the currently merged Metricset tablespace. It shows:

  • Green: Average data file size by filename
  • Orange: Maximum data file size by filename
  • Blue: Tablespace total Size.
  • Horizontal green: Ratio of used space in Tablespaces (used/total)
  • Grey: Ratio of used space in data files (used/total)

@sayden sayden added Metricbeat Metricbeat Team:Integrations Label for the Integrations team labels Jul 1, 2019
@sayden sayden requested a review from a team as a code owner July 1, 2019 13:43
@sayden sayden self-assigned this Jul 1, 2019
@sayden sayden requested a review from a team as a code owner July 1, 2019 14:16
@sayden sayden force-pushed the feature/xp/mb/add-tablespace-dashboard-to-oracle branch from 3fb5e5e to 26e8115 Compare July 1, 2019 14:17
jsoriano
jsoriano reviewed Jul 1, 2019
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good, I wonder if we should name this dashboard "Overview" as is quite tablespaces-specific.

Orange: Maximum data file size by filename

What does this maximum represent? Is this a limit? It is weird to see that for the same file the average size is 590MB and the maximum is 32GB.

Blue: Tablespace total Size.

Should this total size match the sum of files in the other "data file size" dashboards?

x-pack/metricbeat/module/oracle/_meta/kibana/7/dashboard/Metricbet-Oracle-tablespaces.json Outdated Show resolved Hide resolved
metricbeat/docs/modules_list.asciidoc Show resolved Hide resolved
@sayden sayden added the review label Jul 2, 2019
@sayden sayden force-pushed the feature/xp/mb/add-tablespace-dashboard-to-oracle branch from 26e8115 to d6f5332 Compare July 3, 2019 10:27
@sayden
Copy link
Contributor Author

sayden commented Jul 3, 2019 •
edited

This is looking good, I wonder if we should name this dashboard "Overview" as is quite tablespaces-specific.

Orange: Maximum data file size by filename

What does this maximum represent? Is this a limit? It is weird to see that for the same file the average size is 590MB and the maximum is 32GB.

Blue: Tablespace total Size.

Should this total size match the sum of files in the other "data file size" dashboards?

What will look ok for you if the average looks weird? Can you develop?

A tablespace in an Oracle database consists of one or more physical datafiles. A datafile can be associated with only one tablespace and only one database. The size of a datafile is the Maximum data file, no datafile in a tablespace can be bigger than this. This is the docs from Oracle of the table where this data comes from: https://docs.oracle.com/en/database/oracle/oracle-database/12.2/refrn/DBA_DATA_FILES.html

The tablespace total size is the sum of the files, yes. You saw it here already where you can see in deeper detail what it is: https://github.com/elastic/beats/blob/master/x-pack/metricbeat/module/oracle/tablespace/used_and_free_space.go#L29 The table used is the same than above plus this one https://docs.oracle.com/en/database/oracle/oracle-database/12.2/refrn/DBA_FREE_SPACE.html

@exekias
Copy link
Contributor

exekias commented Jul 4, 2019

I would say let's merge this and maybe revisit when we have more data

@exekias exekias added the needs_backport PR is waiting to be backported to other branches. label Jul 4, 2019
@sayden sayden merged commit c67fe8f into elastic:master Jul 4, 2019
sayden added a commit to sayden/beats that referenced this pull request Jul 4, 2019
@sayden
[Metricbeat] Add Tablespaces dashboard to Oracle module (elastic#12736)
1b49481 
(cherry picked from commit c67fe8f)
@sayden sayden mentioned this pull request Jul 4, 2019
Merged
sayden added a commit that referenced this pull request Jul 5, 2019
@sayden
[Metricbeat] Add Tablespaces dashboard to Oracle module (#12736) (#12789
9c92256 
)

(cherry picked from commit c67fe8f)
@jsoriano jsoriano removed the needs_backport PR is waiting to be backported to other branches. label Aug 29, 2019
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@sayden
[Metricbeat] Add Tablespaces dashboard to Oracle module (elastic#12736)…
206ec3e 
… (elastic#12789)

(cherry picked from commit 80a4b05)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoriano jsoriano jsoriano left review comments

@exekias exekias exekias approved these changes

Assignees

@sayden sayden

Labels
Metricbeat Metricbeat review Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sayden @exekias @jsoriano @andresrc