New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add statistic option to cloudwatch metricset config #12840
Add statistic option to cloudwatch metricset config #12840
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great! It will need a changelog entry (don't forget to add an entry in Breaking Changes section too)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks ok. I'll be nice to add some comments in some parts of the code so that it's easier to understand it in the future
…resourceTypeFilters
Nice work! |
Thanks! Yep it should support pNN.NN as well! |
This PR is to add
statistic
as an optional parameter incloudwatch
metricset configuration. If there is nostatistic
given, then the default statistic methods will be applied: Average, Sum, Maximum, Minimum and SampleCount.New
cloudwatch
configuration looks like:How to test it
mage update; mage build; ./metricbeat modules enable aws
to build metricbeat and enable aws module./modules.d/aws.yml
to only keep the part forcloudwatch
metricsetAWS_ACCESS_KEY_ID=<access-key-id> AWS_SECRET_ACCESS_KEY=<secret-access-key> AWS_SESSION_TOKEN=<session-token> AWS_REGION=us-east-1 ./metricbeat -e -c metricbeat.yml -d "publish"
credential_profile_name: test-mb
into./modules.d/aws.yml
to use credential profile and starts metricbeat with./metricbeat -e
all EC2 instances with only
CPUUtilization.max
,DiskWriteOps.max
,CPUUtilization.min
andDiskWriteOps.min
all EBS and ELB metrics
EC2 and ELB with tags
no tags for EBS
EBS metrics with only
.avg
statisticELB metrics with all 5 different statistics
closes #12370
closes #12933