Change the fields exported by flows #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Export the following fields: "_source": {
"@timestamp": "2016-04-03T21:27:20.006Z",
"beat": {
"hostname": "mar.local",
"name": "mar.local"
},
"dest": {
"ip": "172.16.2.200",
"port": 8081,
"stats": {
"net_bytes_total": 2768,
"net_packets_total": 13
}
},
"source": {
"ip": "172.16.2.1",
"port": 59720,
"stats": {
"net_bytes_total": 1394,
"net_packets_total": 14
}
},
"final": false,
"flow_id": "EAT/////AP//////CP8AAAGsEAIBrBACyEjpkR8",
"last_time": "2016-04-03T21:26:54.771Z",
"start_time": "2016-04-03T21:26:54.771Z",
"tags": [
"service-X",
"web-tier"
],
"transport": "tcp",
"type": "flow"
},
|
monicasarbu
force-pushed
the
change_export_fields
branch
from
d74f7ba
to
c175da4
Compare
| - name: ip4 | ||
| description: > | ||
| Innermost IPv4 source address as indicated by first packet seen for the | ||
| current flow. |
There was a problem hiding this comment.
Can you use spaces instead of tabs? Just to keep the same formatting as in the rest of the file.
There was a problem hiding this comment.
It uses only spaces.
|
LGTM. @urso should check that nothing is lost in the reorg. |
|
|
||
|
|
||
| ==== mac_dest | ||
| ==== outter_vlan |
There was a problem hiding this comment.
oh, typo. Just figured it must say 'outer', not 'outter'. I'm afraid this error is all over the place.
monicasarbu
force-pushed
the
change_export_fields
branch
from
c175da4
to
cc04290
Compare
|
|
||
| for _, name := range ipFieldNames { | ||
| source[name[1]] = getLocation(source, name[0]) | ||
| dest[name[1]] = getLocation(dest, name[0]) |
There was a problem hiding this comment.
This sets "ip6_location" to "", even if no "ip6" address is in source/dest. We should only set field, if address really in event
There was a problem hiding this comment.
Thanks, I forgot to add the check.
monicasarbu
force-pushed
the
change_export_fields
branch
from
9cd8615
to
e522f39
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.