Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 7.16 breaking changes #29300

Merged
merged 3 commits into from
Dec 8, 2021
Merged

Add 7.16 breaking changes #29300

merged 3 commits into from
Dec 8, 2021

Conversation

dedemorton
Copy link
Contributor

@dedemorton dedemorton commented Dec 6, 2021 •
edited

What does this PR do?

Adds breaking changes that we want to highlight in 7.16. Remember that these are the highlights that get pulled into the stack upgrade docs.

Preview link: https://beats_29300.docs-preview.app.elstc.co/guide/en/beats/libbeat/master/breaking-changes-7.16.html

Why is it important?

Users need to be aware of these changes.

Checklist

  • My code follows the style guidelines of this project

Related issues

@dedemorton dedemorton self-assigned this Dec 6, 2021
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 6, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 6, 2021

This pull request does not have a backport label. Could you fix it @dedemorton? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Dec 6, 2021
@dedemorton dedemorton added the Team:Docs Label for the Observability docs team label Dec 6, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-docs (Team:Docs)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 6, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 6, 2021 •
edited by jenkins-beats-ci bot

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-07T21:52:35.568+0000

  • Duration: 15 min 25 sec

  • Commit: 1499208

Steps errors 2

Expand to view the steps failures

make check
  • Took 8 min 40 sec . View more details here
  • Description: make check
Error signal
  • Took 0 min 0 sec . View more details here
  • Description: Error 'hudson.AbortException: script returned exit code 2'

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@dedemorton dedemorton mentioned this pull request Dec 7, 2021
Merged
@dedemorton
Copy link
Contributor Author

/test

@dedemorton dedemorton mentioned this pull request Dec 7, 2021
Merged
3 tasks
@dedemorton
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/docs skiplinkcheck

@nimarezainia
Copy link
Contributor

Hi @dedemorton, should we add the deprecation of beats generator and journald in the release notes as well? I know they are mentioned in the BC.

otherwise looks good to me. thx

@dedemorton
Copy link
Contributor Author

The changelog already shows journalbeat being removed. I'm surprised the beats generator deprecation isn't listed there, but maybe we can add it in a follow-on PR? I want to merge this today before I stop working.

@dedemorton dedemorton added backport-v7.16.0 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Dec 8, 2021
@dedemorton dedemorton merged commit 07383bb into elastic:master Dec 8, 2021
@dedemorton dedemorton deleted the issue#1291 branch December 8, 2021 05:48
mergify bot pushed a commit that referenced this pull request Dec 8, 2021
@dedemorton
Add 7.16 breaking changes (#29300)
cfbf3b7 
* Add 7.16 breaking changes

* Resolve feedback from kvch

* Add BC about Beats generator code

(cherry picked from commit 07383bb)
@mergify mergify bot mentioned this pull request Dec 8, 2021
Merged
dedemorton added a commit that referenced this pull request Dec 8, 2021
@mergify @dedemorton
Add 7.16 breaking changes (#29300) (#29337)
4b3009d 
* Add 7.16 breaking changes

* Resolve feedback from kvch

* Add BC about Beats generator code

(cherry picked from commit 07383bb)

Co-authored-by: DeDe Morton <dede.morton@elastic.co>
@dedemorton dedemorton mentioned this pull request Dec 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvch kvch kvch left review comments

@nimarezainia nimarezainia nimarezainia approved these changes

Assignees

@dedemorton dedemorton

Labels
backport-v7.16.0 Automated backport with mergify docs Journalbeat Team:Docs Label for the Observability docs team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Request] Update 7.16 Release Notes regarding Journalbeat replacement
4 participants
@dedemorton @elasticmachine @nimarezainia @kvch