Support per-module docker compose files for metricbeat tests #13186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
added
in progress
jsoriano
changed the title
|
jenkins, test this again please |
jsoriano
force-pushed
the
metricbeat-test-files-to-modules
branch
5 times, most recently
from
b0b2896
to
7587650
Compare
jsoriano
force-pushed
the
metricbeat-test-files-to-modules
branch
from
7587650
to
3b9f0fc
Compare
|
jenkins, test this again please |
|
jenkins, test this again |
6 tasks
|
This is really cool. Looking forward to give a review 👍 |
|
@sayden thanks! go for it, I have just opened this for review 🙂 |
jsoriano
added
[zube]: In Review
review
Metricbeat
sayden
reviewed
Sep 19, 2019
| project.up( | ||
| strategy=ConvergenceStrategy.always, | ||
| service_names=cls.COMPOSE_SERVICES, | ||
| do_build=BuildAction.force, | ||
| do_build=BuildAction.skip, |
There was a problem hiding this comment.
Are you sure about this change?
There was a problem hiding this comment.
Yes, after adding a explicit project.build it is not needed to build also in project.up. The reason to add an explicit project.build is that project.up doesn't allow to pass build arguments.
sayden
approved these changes
Sep 19, 2019
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify docker compose helpers so they can start scenarios
using different docker compose files, what will allow to define
docker compose scenarios per module.
Apache service definition is moved to its own docker compose
file.
Related to #12909