New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support per-module docker compose files for metricbeat tests #13186
Merged
jsoriano
merged 14 commits into
elastic:master
from
jsoriano:metricbeat-test-files-to-modules
Sep 19, 2019
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
d7b7b48
Move apache docker-compose to its own directory
jsoriano ec9f593
Allow to configure build args per test
jsoriano f57b963
Ensure compose projects are isolated
jsoriano 7b897b6
Delete scenarios from modules
jsoriano 156e936
Pep8
jsoriano caac4e5
Add comment
jsoriano 9191143
Stop containers when test finishes
jsoriano ad566e6
Skip data tests earier so no dockers are started for them
jsoriano ae9353a
Remove Old()
jsoriano d7c0323
Go back to kill errors
jsoriano 3b9f0fc
Ignore compose services not defined in current compose file
jsoriano 4279033
Fix typo in comment
jsoriano bfa6e8f
Merge remote-tracking branch 'origin/master' into metricbeat-test-fil…
jsoriano 7ddc17a
Merge remote-tracking branch 'origin/master' into metricbeat-test-fil…
jsoriano File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
version: '2.3' | ||
|
||
services: | ||
apache: | ||
build: ./_meta | ||
ports: | ||
- 80 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure about this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, after adding a explicit
project.build
it is not needed to build also inproject.up
. The reason to add an explicitproject.build
is thatproject.up
doesn't allow to pass build arguments.