Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libbeat] Update lookslike to 0.3.0 #13498

Merged
merged 5 commits into from
Sep 6, 2019
Merged

Conversation

andrewvc
Copy link
Contributor

@andrewvc andrewvc commented Sep 4, 2019

Updates the go-lookslike library we maintain to 0.3.0 which uses a much improved reflection strategy. This fixed an issue in the last release where Strict() which checked for extra fields wasn't working. As a result some of our tests developed since then didn't assert that the new fields added in #13022 were actually valid. Those tests are fixed in this PR.

@andrewvc andrewvc added in progress Pull request is currently in progress. libbeat Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team technical debt labels Sep 4, 2019
@andrewvc andrewvc self-assigned this Sep 4, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime

@andrewvc andrewvc requested a review from a team as a code owner September 4, 2019 21:53
@andrewvc andrewvc removed the in progress Pull request is currently in progress. label Sep 4, 2019
@andrewvc andrewvc requested a review from ruflin September 4, 2019 21:55
Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

heartbeat/monitors/active/http/http_test.go Outdated Show resolved Hide resolved
@andrewvc
Copy link
Contributor Author

andrewvc commented Sep 6, 2019

Test failures are unrelated

@andrewvc andrewvc merged commit dfd8ed0 into elastic:master Sep 6, 2019
@andrewvc andrewvc deleted the update-lookslike branch September 6, 2019 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants