Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change kubernetes.event.message to text #13964

Merged
merged 2 commits into from
Oct 9, 2019

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Oct 8, 2019

This one fixes #13575.

With this PR, full text search will be possible on kubernetes.event.message field.
Currently full text search was possible but on message field of ECS which was a result of copy_to introduced on #10284. With this change, highlighting of the results also takes place, sth that was not happening before.

How to test it

  1. Run metricset event to monitor a Kubernetes cluster.
  2. Create an event like kubectl run prod-server --image=nginx --namespace=staging
  3. In Kibana create a visualization like https://user-images.githubusercontent.com/1869444/64605378-48cdac00-d3c4-11e9-8a0c-5df047f8a560.png and perform a full text search on the search bar. Results should be found and be highlighted.

@ChrsMark ChrsMark requested a review from a team as a code owner October 8, 2019 13:15
@ChrsMark ChrsMark self-assigned this Oct 8, 2019
@exekias
Copy link
Contributor

exekias commented Oct 8, 2019

LGTM! It seems this will need a rebase + mage update. Also a changelog

Signed-off-by: chrismark <chrismarkou92@gmail.com>
Signed-off-by: chrismark <chrismarkou92@gmail.com>
@ChrsMark
Copy link
Member Author

ChrsMark commented Oct 9, 2019

jenkins, test this again please

@ChrsMark
Copy link
Member Author

ChrsMark commented Oct 9, 2019

Failing test seems to be unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug containers Related to containers use case Metricbeat Metricbeat review Team:Integrations Label for the Integrations team test-plan Add this PR to be manual test plan v7.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[metricbeat] kubernetes.event.message should be type string
3 participants