Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Heartbeat] Record TLS Metadata for expired/invalid certs (#14588) #14621

Merged
merged 2 commits into from
Nov 22, 2019

Conversation

andrewvc
Copy link
Contributor

This patch fixes #13687 .

Previously heartbeat would only traverse valid x509 cert chains, with
this PR it now traverses all certs provided by the server.

(cherry picked from commit eff54c3)

)

This patch fixes elastic#13687 .

Previously heartbeat would only traverse valid x509 cert chains, with
this PR it now traverses all certs provided by the server.

(cherry picked from commit eff54c3)
@andrewvc andrewvc added bug backport Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team v7.5.0 labels Nov 19, 2019
@andrewvc andrewvc requested a review from ruflin November 19, 2019 17:39
@andrewvc andrewvc requested a review from a team as a code owner November 19, 2019 17:39
@andrewvc andrewvc self-assigned this Nov 19, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (:uptime)

@@ -49,6 +49,11 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha2...master[Check the HEAD d

*Heartbeat*

- Fix NPEs / resource leaks when executing config checks. {pull}11165[11165]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too much?

Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides the changelog

@andrewvc andrewvc merged commit a4e631c into elastic:7.5 Nov 22, 2019
@andrewvc andrewvc deleted the backport_14588_7.5 branch November 22, 2019 21:06
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
) (elastic#14621)

This patch fixes elastic#13687 .

Previously heartbeat would only traverse valid x509 cert chains, with
this PR it now traverses all certs provided by the server.

(cherry picked from commit b69ecd2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport bug Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team v7.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants