Refactoring of output/mode/lb package #1551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
blocked by #1550 |
- Combine and move load balancer modes into output/mode/lb package (removes
some duplicate code):
- Split load balancer functionality into 3 components each:
- Load balancer module forwarding events to workers
- Context (queueing) defining load balancing strategy + redistribution of
events on retry
- Specialized sync/async workers processing events from context into
(sync/async) protocol clients.
Workers deal with client errors (reconnect + backoff strategy) and
return unsuccessfully send events back into the load balancer context
- async load balance worker always spawns go-routine for returning errors into
retry queue (break potential deadlocks if errors are reported via queues).
urso
force-pushed
the
refactor/output-modes-lb
branch
from
76d69f6
to
1c7b625
Compare
| event common.MapStr, | ||
| ) error { | ||
| return m.publishEventsMessage(opts, eventsMessage{ | ||
| worker: -1, |
There was a problem hiding this comment.
Just for my knowledge, what does the -1 signify here?
There was a problem hiding this comment.
worker is the worker-id processing a message. That is on error we can tell which worker did error. With ids currently starting with 0, the value -1 indicates the message not being processed before.
|
LGTM, waiting for travis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some duplicate code):
events on retry
(sync/async) protocol clients.
Workers deal with client errors (reconnect + backoff strategy) and
return unsuccessfully send events back into the load balancer context
retry queue (break potential deadlocks if errors are reported via queues).