Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where default go logger is not discarded when either * or stdout is selected. #15708

Merged
merged 6 commits into from
Jan 27, 2020

Conversation

blakerouse
Copy link
Contributor

@blakerouse blakerouse commented Jan 21, 2020

What does this PR do?

Fix issue where default go logger is not discarded when either * or stdout is selected.

Why is it important?

Prevents other imported modules from outputting log messages.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works

Related issues

@blakerouse blakerouse added the bug label Jan 21, 2020
@blakerouse blakerouse requested a review from ph January 21, 2020 17:06
@urso
Copy link

urso commented Jan 24, 2020

@ph @andrewkroh Can you have a look, please?

@urso urso requested review from andrewkroh and ph January 24, 2020 16:02
ph
ph previously approved these changes Jan 24, 2020
Copy link
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looked through the previous issues.

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm understanding the original issue correctly I think another change is needed.

libbeat/logp/core.go Outdated Show resolved Hide resolved
libbeat/logp/core_test.go Outdated Show resolved Hide resolved
@ph
Copy link
Contributor

ph commented Jan 24, 2020

I need to check my zube rules for this, i've missed you initial ping @blakerouse

@ph ph dismissed their stale review January 24, 2020 17:44

Based on @andrewkroh comment I need to remove it.

@blakerouse
Copy link
Contributor Author

@andrewkroh @ph Adjusted the code based on the review, if you could give this another look.

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's missing a changelog entry.

@blakerouse blakerouse merged commit 1838734 into elastic:master Jan 27, 2020
@blakerouse blakerouse added the needs_backport PR is waiting to be backported to other branches. label Jan 27, 2020
@blakerouse blakerouse deleted the fix-10251 branch January 27, 2020 19:00
@blakerouse blakerouse added v7.7.0 and removed needs_backport PR is waiting to be backported to other branches. labels Jan 27, 2020
@andresrc andresrc added the Team:Integrations Label for the Integrations team label Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logger from the standard library is not correctly disabled.
5 participants