Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set event.outcome based on googlecloud audit log output #15731

Merged
merged 12 commits into from
Jan 23, 2020
Merged

Set event.outcome based on googlecloud audit log output #15731

merged 12 commits into from
Jan 23, 2020

Conversation

alakahakai
Copy link

Set event.outcome based on googlecloud audit log output

@alakahakai alakahakai requested a review from a team as a code owner January 22, 2020 06:02
@alakahakai alakahakai added review needs_backport PR is waiting to be backported to other branches. labels Jan 22, 2020
@alakahakai alakahakai requested a review from a team January 23, 2020 00:23
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

andrewkroh
andrewkroh approved these changes Jan 23, 2020
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests look good. I think this will make it simpler to use the data.

x-pack/filebeat/module/googlecloud/audit/config/pipeline.js Outdated Show resolved Hide resolved
x-pack/filebeat/module/googlecloud/audit/config/pipeline.js Outdated Show resolved Hide resolved
x-pack/filebeat/module/googlecloud/audit/config/pipeline.js Outdated Show resolved Hide resolved
@alakahakai alakahakai merged commit ffae2c4 into elastic:master Jan 23, 2020
@alakahakai alakahakai mentioned this pull request Jan 23, 2020
Merged
@alakahakai alakahakai removed the needs_backport PR is waiting to be backported to other branches. label Jan 23, 2020
@alakahakai alakahakai mentioned this pull request Jan 23, 2020
Merged
alakahakai pushed a commit that referenced this pull request Jan 27, 2020
Set event.outcome based on googlecloud audit log output (#15731) (#15766
f4f10ae 
)

* Set event.outcome based on googlecloud audit log output

(cherry picked from commit ffae2c4)
alakahakai pushed a commit that referenced this pull request Jan 27, 2020
Set event.outcome based on googlecloud audit log output (#15731) (#15767
baaaaf4 
)

* Set event.outcome based on googlecloud audit log output

(cherry picked from commit ffae2c4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees
No one assigned
Labels
review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alakahakai @elasticmachine @andrewkroh