Export cpu usage in percentage by default #1705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monicasarbu
force-pushed
the
export_cpu_usage_in_percentage_by_default
branch
from
394127b
to
818424b
Compare
monicasarbu
force-pushed
the
export_cpu_usage_in_percentage_by_default
branch
from
b92e6d4
to
cb40022
Compare
| - name: irq | ||
| type: integer | ||
| description: > | ||
| The amount of CPU time spent servicing and handling hardware interrupts. | ||
|
|
||
| - name: irq_p | ||
| type: integer |
There was a problem hiding this comment.
It should be float. I am fixing it.
|
In general LGTM. Somme suggestions/comments:
|
monicasarbu
force-pushed
the
export_cpu_usage_in_percentage_by_default
branch
from
9b9b1c8
to
6f76d43
Compare
|
I updated the PR with all the comments. @ruflin I kept |
monicasarbu
force-pushed
the
export_cpu_usage_in_percentage_by_default
branch
2 times, most recently
from
4bee927
to
4cd909a
Compare
|
jenkins, test it |
monicasarbu
force-pushed
the
export_cpu_usage_in_percentage_by_default
branch
from
4cd909a
to
9ef54d0
Compare
| @@ -13,10 +13,11 @@ topbeat.procs: [ | |||
|
|
|||
| # Statistics to collect (all enabled by default) | |||
| topbeat.stats: | |||
| system: {{ "false" if system_stats == false else "true" }} | |||
There was a problem hiding this comment.
Looks like this is 4 spaces now. Does it still work? Is there a need to change this?
There was a problem hiding this comment.
Yes, I think it's working. Adding more spaces at each line wasn't on purpose.
|
LGTM |
|
jenkins, test it |
monicasarbu
force-pushed
the
export_cpu_usage_in_percentage_by_default
branch
from
d16500a
to
4419741
Compare
The following changes are included in the PR: - Exports CPU usage in percentage (default behaviour) - Add `cpu_ticks` option in the system module of Metricbeat and Topbeat. If it's enabled, it exports the CPU usage in ticks together with the values in percentages. By default is false. - Export CPU stats per core in `type=core` documents instead of `type=system` documents.
monicasarbu
force-pushed
the
export_cpu_usage_in_percentage_by_default
branch
from
4419741
to
142c71b
Compare
|
jenkins, test it |
This was referenced Aug 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, I did the minimal changes that Topbeat and Metricbeat to export (by default) the CPU usage statistics in percentage instead of CPU ticks. The percentages are:
cpu.iowait_p,cpu.idle_p,cpu.irq_p,cpu.nice_p,cpu.softirq_p,cpu.steal_p,cpu.system_pandcpu.user_p.proc.cpu.total_pIf the user is interested in exporting the CPU usage in ticks , he/she needs to set the configuration option
cpu_usage_in_ticksto true. The following values are exported in addition to the CPU usage in percentage:cpu.iowait,cpu.idle,cpu.irq,cpu.nice,cpu.softirq,cpu.stealproc.cpu.user,proc.cpu.system,proc.cpu.totalcore.iowait,core.idle,core.irq,core.nice,core.softirq,core.stealWe don't need to change the Topbeat dashboard as the values that we are making optional, are not used in the dashboard.
cc-ed: @tsg @simianhacker @ruflin @andrewkroh