Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Heartbeat] Fix concurrency errors with multiple ports #17262

Merged
merged 4 commits into from Mar 26, 2020

Conversation

andrewvc
Copy link
Contributor

@andrewvc andrewvc commented Mar 26, 2020

What does this PR do?

Fixes #16917 , where in heartbeat 6.x multiple TCP ports cause a crash with configs like this one.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@andrewvc andrewvc added bug Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team v6.8.9 labels Mar 26, 2020
@andrewvc andrewvc requested a review from urso March 26, 2020 14:03
@andrewvc andrewvc self-assigned this Mar 26, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (:uptime)

@urso
Copy link

urso commented Mar 26, 2020

I presume this is a workaround for 6.8 only? Instead of one DNS lookup, this change will trigger a DNS lookup per port number, if actual host names are configured.

@andrewvc
Copy link
Contributor Author

@urso that's correct about the DNS lookup. I'm OK with that, as I doubt that's a limiting factor in most cases, and I don't think a more extensive restructuring of the code is warranted in 6.x

@andrewvc
Copy link
Contributor Author

Hmmm, there is some additional problem here that is causing additional test failures due to checks not running. Investigating.

@andrewvc andrewvc merged commit d421970 into elastic:6.8 Mar 26, 2020
@andrewvc andrewvc deleted the fix-multi-port branch March 26, 2020 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team v6.8.9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants